itsscb/askama
1
0
Fork 0
mirror of https://github.com/askama-rs/askama.git synced 2025-10-01 15:00:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix undetected cyclic dependency

Browse Source
This commit is contained in:
Guillaume Gomez 2024-04-11 20:23:14 +02:00
parent 66b53eecaf
commit 1899765230
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
askama_derive/src/input.rs
View File

@ -140,15 +140,12 @@ impl TemplateInput<'_> {
Extends(extends) if top => {
let extends = self.config.find_template(extends.path, Some(&path))?;
let dependency_path = (path.clone(), extends.clone());
if dependency_graph.contains(&dependency_path) {
return Err(format!(
"cyclic dependency in graph {:#?}",
dependency_graph
.iter()
.map(|e| format!("{:#?} --> {:#?}", e.0, e.1))
.collect::<Vec<String>>()
)
.into());
if path == extends {
// We add the path into the graph to have a better looking error.
dependency_graph.push(dependency_path);
return cyclic_graph_error(&dependency_graph);
} else if dependency_graph.contains(&dependency_path) {
return cyclic_graph_error(&dependency_graph);
}
dependency_graph.push(dependency_path);
add_to_check(extends)?;
@ -420,6 +417,17 @@ const TEXT_TYPES: [(Mime, Mime); 7] = [
(mime::IMAGE_SVG, mime::IMAGE_SVG),
];
fn cyclic_graph_error(dependency_graph: &[(Rc<Path>, Rc<Path>)]) -> Result<(), CompileError> {
Err(format!(
"cyclic dependency in graph {:#?}",
dependency_graph
.iter()
.map(|e| format!("{:#?} --> {:#?}", e.0, e.1))
.collect::<Vec<String>>()
)
.into())
}
#[cfg(test)]
mod tests {
use super::*;