itsscb/askama
1
0
Fork 0
mirror of https://github.com/askama-rs/askama.git synced 2025-09-29 05:51:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix off-by-one error with HTML escaping

Browse Source 
If the second-to-last character of a string should be escaped,
but not the last, the last character was not being included in the
result.
This commit is contained in:
Benjamin Li 2018-10-24 16:46:20 -04:00 committed by Dirkjan Ochtman
parent 5be6479f2c
commit 7062aabbcb
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
askama_shared/src/escaping.rs
View File

@ -96,7 +96,7 @@ pub fn escape(s: String) -> String {
_ => panic!("incorrect indexing"),
}
}
if start < bytes.len() - 1 {
if start < bytes.len() {
res.extend(&bytes[start..]);
}
@ -112,5 +112,6 @@ mod tests {
assert_eq!(escape("<&>".to_string()), "&lt;&amp;&gt;");
assert_eq!(escape("bla&".to_string()), "bla&amp;");
assert_eq!(escape("<foo".to_string()), "&lt;foo");
assert_eq!(escape("bla&h".to_string()), "bla&amp;h");
}
}