itsscb/cargo
1
0
Fork 0
mirror of https://github.com/rust-lang/cargo.git synced 2025-09-25 11:14:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(build-std): move away from panic_immediate_abort (#16006)

Browse Source 
### What does this PR try to resolve?

The test exercises a regression of extra `-Zbuild-std-features`
overriding the entire default-features set.
However, after rust-lang/rust#146317 panic_immediate_abort
became a codegen flag not a Cargo feature anymore.
We pick another `optimize_for_size` feature flag to ensure the
regression case is still covered.

### How to test and review this PR?

To verify `optimize_for_size` actually triggers the regression,
git revert f004691aa41449fa06b764683385558edee51428
and changes to `-Zbuild-std-features=optimize_for_size`.

Alternatively, we can just drop this test.
This commit is contained in:
Scott Schafer 2025-09-24 05:35:07 +00:00 committed by GitHub
commit 113761f27a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/build-std/main.rs
View File

@ -396,7 +396,9 @@ fn test_proc_macro() {
} }
#[cargo_test(build_std_real)] #[cargo_test(build_std_real)]
fn test_panic_abort() { fn default_features_still_included_with_extra_build_std_features() {
// This is a regression test to ensure when adding extra `build-std-features`,
// the default feature set is still respected and included.
// See rust-lang/cargo#14935 // See rust-lang/cargo#14935
let p = project() let p = project()
.file( .file(
@ -413,7 +415,7 @@ fn test_panic_abort() {
p.cargo("check") p.cargo("check")
.build_std_arg("std,panic_abort") .build_std_arg("std,panic_abort")
.env("RUSTFLAGS", "-C panic=abort") .env("RUSTFLAGS", "-C panic=abort")
.arg("-Zbuild-std-features=panic_immediate_abort") .arg("-Zbuild-std-features=optimize_for_size")
.run(); .run();
} }