itsscb/cargo
1
0
Fork 0
mirror of https://github.com/rust-lang/cargo.git synced 2025-09-25 11:14:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a note to the error message for using --feature / --no-default-features in a virtual workspace

Browse Source
This commit is contained in:
Jonas Platte 2019-12-24 13:29:38 +01:00
parent 86134e7666
commit 2166db8c49
No known key found for this signature in database
GPG Key ID: 7D261D771D915378
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/cargo/util/command_prelude.rs
View File

@ -289,7 +289,8 @@ pub trait ArgMatchesExt {
for flag in &["features", "no-default-features"] {
if self._is_present(flag) {
bail!(
"--{} is not allowed in the root of a virtual workspace",
"--{} is not allowed in the root of a virtual workspace\n\
note: while this was previously accepted, it didn't actually do anything",
flag
);
}

8
tests/testsuite/features.rs
View File

@ -2017,13 +2017,17 @@ fn virtual_ws_flags() {
.build();
p.cargo("build --features=f1")
.with_stderr("[ERROR] --features is not allowed in the root of a virtual workspace")
.with_stderr(
"[ERROR] --features is not allowed in the root of a virtual workspace\n\
note: while this was previously accepted, it didn't actually do anything",
)
.with_status(101)
.run();
p.cargo("build --no-default-features")
.with_stderr(
"[ERROR] --no-default-features is not allowed in the root of a virtual workspace",
"[ERROR] --no-default-features is not allowed in the root of a virtual workspace\n\
note: while this was previously accepted, it didn't actually do anything",
)
.with_status(101)
.run();