test: Add asserts to catch BorrowMutError's

This intentionally borrows from `RefCell`s before conditional code
to try to prevent regressions like #13646 without exhaustively
covering every case that could hit these `BorrowMutError`s with
complicated tests.

I tested this by ensuring the registry code path panicked before
rebasing on top of #13647.
Once I rebased, the panic went away.

Co-authored-by: Ed Page <eopage@gmail.com>
This commit is contained in:
Ed Page 2024-03-26 11:12:57 -05:00 committed by Weihang Lo
parent 3a77350b77
commit 309cd9387c
No known key found for this signature in database
GPG Key ID: D7DBF189825E82E7
2 changed files with 9 additions and 0 deletions

View File

@ -739,6 +739,11 @@ impl<'gctx> Registry for PackageRegistry<'gctx> {
}
fn block_until_ready(&mut self) -> CargoResult<()> {
if cfg!(debug_assertions) {
// Force borrow to catch invalid borrows, regardless of which source is used and how it
// happens to behave this time
self.gctx.shell().verbosity();
}
for (source_id, source) in self.sources.sources_mut() {
source
.block_until_ready()

View File

@ -392,6 +392,10 @@ fn acquire(
lock_try: &dyn Fn() -> io::Result<()>,
lock_block: &dyn Fn() -> io::Result<()>,
) -> CargoResult<()> {
if cfg!(debug_assertions) {
// Force borrow to catch invalid borrows outside of contention situations
gctx.shell().verbosity();
}
if try_acquire(path, lock_try)? {
return Ok(());
}