itsscb/cargo
1
0
Fork 0
mirror of https://github.com/rust-lang/cargo.git synced 2025-10-01 11:30:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix random Windows CI error for changing_bin_features_caches_targets

Browse Source 
Fixes #5481.
This commit is contained in:
Eric Huss 2018-05-06 08:25:44 -07:00
parent b429a3649c
commit 352114472f
1 changed files with 46 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

65
tests/testsuite/freshness.rs
View File

@ -2,9 +2,9 @@ use std::fs::{self, File};
use std::io::prelude::*; use std::io::prelude::*;
use cargotest::sleep_ms; use cargotest::sleep_ms;
use cargotest::support::{execs, project, path2url};
use cargotest::support::paths::CargoPathExt; use cargotest::support::paths::CargoPathExt;
use cargotest::support::registry::Package; use cargotest::support::registry::Package;
use cargotest::support::{execs, path2url, project};
use hamcrest::{assert_that, existing_file}; use hamcrest::{assert_that, existing_file};
#[test] #[test]
@ -515,61 +515,72 @@ fn changing_bin_features_caches_targets() {
) )
.build(); .build();
// Windows has a problem with replacing a binary that was just executed.
// Unlinking it will succeed, but then attempting to immediately replace
// it will sometimes fail with "Already Exists".
// See https://github.com/rust-lang/cargo/issues/5481
let foo_proc = |name: &str| {
let src = p.bin("foo");
let dst = p.bin(name);
fs::copy(&src, &dst).expect("Failed to copy foo");
p.process(dst)
};
assert_that( assert_that(
p.cargo("run"), p.cargo("build"),
execs() execs().with_status(0).with_stderr(
.with_status(0)
.with_stdout("feature off")
.with_stderr(
"\ "\
[..]Compiling foo v0.0.1 ([..]) [COMPILING] foo v0.0.1 ([..])
[FINISHED] dev [unoptimized + debuginfo] target(s) in [..] [FINISHED] dev [unoptimized + debuginfo] target(s) in [..]
[RUNNING] `target[/]debug[/]foo[EXE]`
", ",
), ),
); );
assert_that(
foo_proc("off1"),
execs().with_status(0).with_stdout("feature off"),
);
assert_that( assert_that(
p.cargo("run").arg("--features").arg("foo"), p.cargo("build").arg("--features").arg("foo"),
execs() execs().with_status(0).with_stderr(
.with_status(0)
.with_stdout("feature on")
.with_stderr(
"\ "\
[..]Compiling foo v0.0.1 ([..]) [COMPILING] foo v0.0.1 ([..])
[FINISHED] dev [unoptimized + debuginfo] target(s) in [..] [FINISHED] dev [unoptimized + debuginfo] target(s) in [..]
[RUNNING] `target[/]debug[/]foo[EXE]`
", ",
), ),
); );
assert_that(
foo_proc("on1"),
execs().with_status(0).with_stdout("feature on"),
);
/* Targets should be cached from the first build */ /* Targets should be cached from the first build */
assert_that( assert_that(
p.cargo("run"), p.cargo("build"),
execs() execs().with_status(0).with_stderr(
.with_status(0)
.with_stdout("feature off")
.with_stderr(
"\ "\
[FINISHED] dev [unoptimized + debuginfo] target(s) in [..] [FINISHED] dev [unoptimized + debuginfo] target(s) in [..]
[RUNNING] `target[/]debug[/]foo[EXE]`
", ",
), ),
); );
assert_that(
foo_proc("off2"),
execs().with_status(0).with_stdout("feature off"),
);
assert_that( assert_that(
p.cargo("run").arg("--features").arg("foo"), p.cargo("build").arg("--features").arg("foo"),
execs() execs().with_status(0).with_stderr(
.with_status(0)
.with_stdout("feature on")
.with_stderr(
"\ "\
[FINISHED] dev [unoptimized + debuginfo] target(s) in [..] [FINISHED] dev [unoptimized + debuginfo] target(s) in [..]
[RUNNING] `target[/]debug[/]foo[EXE]`
", ",
), ),
); );
assert_that(
foo_proc("on2"),
execs().with_status(0).with_stdout("feature on"),
);
} }
#[test] #[test]