From 42027af7060ec6bb82cec21f7d68ba3987895714 Mon Sep 17 00:00:00 2001 From: Ed Page Date: Tue, 16 Sep 2025 11:12:54 -0500 Subject: [PATCH] refactor(frontmatter): Clarify the span --- src/cargo/util/frontmatter.rs | 8 ++++---- src/cargo/util/toml/mod.rs | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/cargo/util/frontmatter.rs b/src/cargo/util/frontmatter.rs index c3a7a33d2..8192beb9e 100644 --- a/src/cargo/util/frontmatter.rs +++ b/src/cargo/util/frontmatter.rs @@ -286,14 +286,14 @@ fn is_whitespace(c: char) -> bool { #[derive(Debug)] pub struct FrontmatterError { message: String, - span: Span, + primary_span: Span, } impl FrontmatterError { pub fn new(message: impl Into, span: Span) -> Self { Self { message: message.into(), - span, + primary_span: span, } } @@ -301,8 +301,8 @@ impl FrontmatterError { self.message.as_str() } - pub fn span(&self) -> Span { - self.span.clone() + pub fn primary_span(&self) -> Span { + self.primary_span.clone() } } diff --git a/src/cargo/util/toml/mod.rs b/src/cargo/util/toml/mod.rs index 885e49c19..6899d3ef0 100644 --- a/src/cargo/util/toml/mod.rs +++ b/src/cargo/util/toml/mod.rs @@ -2783,7 +2783,7 @@ fn emit_frontmatter_diagnostic( manifest_file: &Path, gctx: &GlobalContext, ) -> anyhow::Error { - let span = e.span(); + let primary_span = e.primary_span(); // Get the path to the manifest, relative to the cwd let manifest_path = diff_paths(manifest_file, gctx.cwd()) @@ -2793,7 +2793,7 @@ fn emit_frontmatter_diagnostic( let group = Group::with_title(Level::ERROR.primary_title(e.message())).element( Snippet::source(contents) .path(manifest_path) - .annotation(AnnotationKind::Primary.span(span)), + .annotation(AnnotationKind::Primary.span(primary_span)), ); if let Err(err) = gctx.shell().print_report(&[group], true) {