itsscb/cargo
1
0
Fork 0
mirror of https://github.com/rust-lang/cargo.git synced 2025-09-25 11:14:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Warning on conflicting default_features keys

Browse Source 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
This commit is contained in:
hi-rustin 2022-02-09 22:15:29 +08:00
parent ed93c94bd1
commit 460ea25377
2 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/cargo/util/toml/mod.rs
View File

@ -1922,6 +1922,13 @@ impl<P: ResolveToPath> DetailedTomlDependency<P> {
let version = self.version.as_deref();
let mut dep = Dependency::parse(pkg_name, version, new_source_id)?;
if self.default_features.is_some() && self.default_features2.is_some() {
cx.warnings.push(format!(
"found both `default-features` and `default_features` are set \
in the `{}` dependency",
name_in_toml
));
}
dep.set_features(self.features.iter().flatten())
.set_default_features(
self.default_features

39
tests/testsuite/features.rs
View File

@ -2067,3 +2067,42 @@ Caused by:
)
.run();
}
#[cargo_test]
fn default_features_conflicting_warning() {
let p = project()
.file(
"Cargo.toml",
r#"
[package]
name = "foo"
version = "0.1.0"
authors = []
[dependencies]
a = { path = "a", features = ["f1"], default-features = false, default_features = false }
"#,
)
.file("src/lib.rs", "")
.file(
"a/Cargo.toml",
r#"
[package]
name = "a"
version = "0.1.0"
authors = []
[features]
default = ["f1"]
f1 = []
"#,
)
.file("a/src/lib.rs", "")
.build();
p.cargo("build")
.with_stderr_contains(
"[WARNING] found both `default-features` and `default_features` are set in the `a` dependency",
)
.run();
}