From 751fd47d346a127e4ccd5862cb6b67c32a1dfb56 Mon Sep 17 00:00:00 2001 From: Ed Page Date: Wed, 24 Apr 2024 14:22:23 -0500 Subject: [PATCH] fix(toml): Don't double-warn when underscore is used in workspace dep --- src/cargo/util/toml/mod.rs | 8 -------- tests/testsuite/bad_config.rs | 2 -- 2 files changed, 10 deletions(-) diff --git a/src/cargo/util/toml/mod.rs b/src/cargo/util/toml/mod.rs index 16cba3cd3..a1d588f4e 100644 --- a/src/cargo/util/toml/mod.rs +++ b/src/cargo/util/toml/mod.rs @@ -904,14 +904,6 @@ fn inner_dependency_inherit_with<'a>( this could become a hard error in the future" )) } - deprecated_underscore( - &dependency.default_features2, - &dependency.default_features, - "default-features", - name, - "dependency", - warnings, - ); inherit()?.get_dependency(name, package_root).map(|d| { match d { manifest::TomlDependency::Simple(s) => { diff --git a/tests/testsuite/bad_config.rs b/tests/testsuite/bad_config.rs index 51a967cae..3b6d9b93d 100644 --- a/tests/testsuite/bad_config.rs +++ b/tests/testsuite/bad_config.rs @@ -1426,8 +1426,6 @@ fn workspace_default_features2() { "\ warning: [CWD]/workspace_only/Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition (in the `dep_workspace_only` dependency) -warning: [CWD]/package_only/Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition -(in the `dep_package_only` dependency) Locking 4 packages to latest compatible versions Checking dep_package_only v0.1.0 ([CWD]/dep_package_only) Checking dep_workspace_only v0.1.0 ([CWD]/dep_workspace_only)