From 88f858a5b5bb7b8ca7ba2daa22037e2cf9907de6 Mon Sep 17 00:00:00 2001 From: Ed Page Date: Fri, 21 Feb 2025 09:11:33 -0600 Subject: [PATCH] refactor(bump): Visual group related operations --- crates/xtask-bump-check/src/xtask.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/crates/xtask-bump-check/src/xtask.rs b/crates/xtask-bump-check/src/xtask.rs index 60dbc7538..d83e0db63 100644 --- a/crates/xtask-bump-check/src/xtask.rs +++ b/crates/xtask-bump-check/src/xtask.rs @@ -114,7 +114,6 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car let base_commit = get_base_commit(gctx, args, &repo)?; let head_commit = get_head_commit(args, &repo)?; let referenced_commit = get_referenced_commit(&repo, &base_commit)?; - let changed_members = changed(&ws, &repo, &base_commit, &head_commit)?; let status = |msg: &str| gctx.shell().status(STATUS, msg); let crates_not_check_against_channels = [ @@ -135,9 +134,8 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car status(&format!("head commit `{}`", head_commit.id()))?; let mut needs_bump = Vec::new(); - + let changed_members = changed(&ws, &repo, &base_commit, &head_commit)?; check_crates_io(&ws, &changed_members, &mut needs_bump)?; - if let Some(referenced_commit) = referenced_commit.as_ref() { status(&format!("compare against `{}`", referenced_commit.id()))?; for referenced_member in checkout_ws(&ws, &repo, referenced_commit)?.members() { @@ -157,7 +155,6 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car } } } - if !needs_bump.is_empty() { needs_bump.sort(); needs_bump.dedup();