itsscb/cargo
1
0
Fork 0
mirror of https://github.com/rust-lang/cargo.git synced 2025-10-01 11:30:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary into conversions (#15042)

Browse Source 
"identity" `.into()` calls where the base's type isn't changed is a
future compatibility foot-gun (like the issue we had with `time` a few
months ago) as new `impl Into` blocks can cause previously compiling
code to start failing. I don't foresee these ones in particular causing
problems anytime soon, but I noticed them and might as well clean them
up as a drive-by.
This commit is contained in:
Weihang Lo 2025-01-09 19:58:12 +00:00 committed by GitHub
commit 9589831f61
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cargo/sources/git/known_hosts.rs
View File

@ -100,7 +100,7 @@ enum KnownHostError {
impl From<anyhow::Error> for KnownHostError { impl From<anyhow::Error> for KnownHostError {
fn from(err: anyhow::Error) -> KnownHostError { fn from(err: anyhow::Error) -> KnownHostError {
KnownHostError::CheckError(err.into()) KnownHostError::CheckError(err)
} }
} }

2
src/cargo/sources/git/utils.rs
View File

@ -1187,7 +1187,7 @@ fn fetch_with_gitoxide(
); );
let outcome = connection let outcome = connection
.prepare_fetch(&mut progress, gix::remote::ref_map::Options::default())? .prepare_fetch(&mut progress, gix::remote::ref_map::Options::default())?
.with_shallow(shallow.clone().into()) .with_shallow(shallow.clone())
.receive(&mut progress, should_interrupt)?; .receive(&mut progress, should_interrupt)?;
Ok(outcome) Ok(outcome)
}); });