itsscb/cargo
1
0
Fork 0
mirror of https://github.com/rust-lang/cargo.git synced 2025-09-28 11:20:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

clippy: warn disallowed_methods for std::env::var and friends

Browse Source 
In 11588 we want to avoid reading from environment variables,
11727 did that well. I wonder if we could leverage tools to help
with this. Thankfully, clippy has a `disallowed_methods`[1] lint,
helping us enforce the rule.

[1]: https://rust-lang.github.io/rust-clippy/stable/index.html#disallowed_methods
This commit is contained in:
Weihang Lo 2023-03-17 09:24:42 +00:00
parent f2f4496bab
commit 9e3bb8588b
No known key found for this signature in database
GPG Key ID: D7DBF189825E82E7
3 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clippy.toml Normal file
View File

@ -0,0 +1,6 @@
disallowed-methods = [
{ path = "std::env::var", reason = "Use `Config::get_env` instead. See rust-lang/cargo#11588" },
{ path = "std::env::var_os", reason = "Use `Config::get_env_os` instead. See rust-lang/cargo#11588" },
{ path = "std::env::vars", reason = "Not recommended to use in Cargo. See rust-lang/cargo#11588" },
{ path = "std::env::vars_os", reason = "Not recommended to use in Cargo. See rust-lang/cargo#11588" },
]

1
src/bin/cargo/main.rs
View File

@ -1,5 +1,6 @@
#![warn(rust_2018_idioms)] // while we're getting used to 2018 #![warn(rust_2018_idioms)] // while we're getting used to 2018
#![allow(clippy::all)] #![allow(clippy::all)]
#![warn(clippy::disallowed_methods)]
use cargo::util::toml::StringOrVec; use cargo::util::toml::StringOrVec;
use cargo::util::CliError; use cargo::util::CliError;

1
src/cargo/lib.rs
View File

@ -4,6 +4,7 @@
// Due to some of the default clippy lints being somewhat subjective and not // Due to some of the default clippy lints being somewhat subjective and not
// necessarily an improvement, we prefer to not use them at this time. // necessarily an improvement, we prefer to not use them at this time.
#![allow(clippy::all)] #![allow(clippy::all)]
#![warn(clippy::disallowed_methods)]
#![warn(clippy::self_named_module_files)] #![warn(clippy::self_named_module_files)]
#![allow(rustdoc::private_intra_doc_links)] #![allow(rustdoc::private_intra_doc_links)]