From a1db0b1383b40cafe50e24499b28e9ea5f840b4b Mon Sep 17 00:00:00 2001 From: Ed Page Date: Mon, 29 Jan 2024 20:45:35 -0600 Subject: [PATCH] fix(update): Don't bother listing pre-release There might be casses where we want to show pre-release as this grows but, for now, there isn't too often a case where an update is held back, you are on a pre-release, your pre-release is updating, and you want a pre-release. --- src/cargo/ops/cargo_generate_lockfile.rs | 1 + tests/testsuite/update.rs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cargo/ops/cargo_generate_lockfile.rs b/src/cargo/ops/cargo_generate_lockfile.rs index 66e9a66c2..051d53065 100644 --- a/src/cargo/ops/cargo_generate_lockfile.rs +++ b/src/cargo/ops/cargo_generate_lockfile.rs @@ -184,6 +184,7 @@ pub fn update_lockfile(ws: &Workspace<'_>, opts: &UpdateOptions<'_>) -> CargoRes possibilities .iter() .map(|s| s.as_summary()) + .filter(|s| s.version().pre.is_empty()) .map(|s| s.version().clone()) .max() .filter(|v| added.version() < v) diff --git a/tests/testsuite/update.rs b/tests/testsuite/update.rs index 2a02991da..a633a7ab3 100644 --- a/tests/testsuite/update.rs +++ b/tests/testsuite/update.rs @@ -1500,7 +1500,7 @@ fn report_behind() { .with_stderr( "\ [UPDATING] `dummy-registry` index -[UPDATING] breaking v0.1.0 -> v0.1.1 (latest: v0.2.1-alpha.0) +[UPDATING] breaking v0.1.0 -> v0.1.1 (latest: v0.2.0) ", ) .run();