From fcff51b3e032c5fe79874f5092aa48244510a3f3 Mon Sep 17 00:00:00 2001 From: Matt Stavola Date: Wed, 8 Apr 2020 23:46:30 -0700 Subject: [PATCH] Add test for bad renaming --- tests/testsuite/build.rs | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/tests/testsuite/build.rs b/tests/testsuite/build.rs index e8bffe5d1..04beef388 100644 --- a/tests/testsuite/build.rs +++ b/tests/testsuite/build.rs @@ -911,6 +911,37 @@ required by package `foo v0.0.1 ([CWD])` .run(); } +// Ensure that renamed deps have a valid name +#[cargo_test] +fn cargo_compile_with_invalid_dep_rename() { + let p = project() + .file( + "Cargo.toml", + r#" + [package] + name = "buggin" + version = "0.1.0" + + [dependencies] + "haha this isn't a valid name 🐛" = { package = "libc", version = "0.1" } + "#, + ) + .file("src/main.rs", &main_file(r#""What's good?""#, &[])) + .build(); + + p.cargo("build") + .with_status(101) + .with_stderr( + "\ +error: failed to parse manifest at `[..]` + +Caused by: + invalid character ` ` in dependency name: `haha this isn't a valid name 🐛`, characters must be Unicode XID characters (numbers, `-`, `_`, or most letters) +", + ) + .run(); +} + #[cargo_test] fn cargo_compile_with_filename() { let p = project()