mirror of
https://github.com/rust-lang/cargo.git
synced 2025-09-28 11:20:36 +00:00
chore(ci): Check for clippy correctness
The fact that we don't check for `derive_ord_xor_partial_ord ` almost bit us in #14663. Instead of just enabling this one lint, I figured it'd be good to audit all of the `deny` by default lints. That is long enough that I was concerned about maintaining it (or bikeshedding which to enable or disable). All `deny` by default lints are `correctness` lints and I figure we could just enable the group. We normally opt-in to individual clippy lints. From what I remember of that conversation, it mostly stems from how liberal clippy is with making a lint `warn` by default. It also makes an unpinned CI more brittle. I figured clippy is more conservative about `deny` by default lints and slower to add them that this is unlikely to be a problem.
This commit is contained in:
parent
49d8696823
commit
fd544063ca
@ -121,7 +121,8 @@ rust_2018_idioms = "warn" # TODO: could this be removed?
|
||||
private_intra_doc_links = "allow"
|
||||
|
||||
[workspace.lints.clippy]
|
||||
all = { level = "allow", priority = -1 }
|
||||
all = { level = "allow", priority = -2 }
|
||||
correctness = { level = "warn", priority = -1 }
|
||||
dbg_macro = "warn"
|
||||
disallowed_methods = "warn"
|
||||
print_stderr = "warn"
|
||||
|
Loading…
x
Reference in New Issue
Block a user