mirror of
https://github.com/rust-lang/cargo.git
synced 2026-03-21 20:03:56 +00:00
bee20ff529
Fixes #15579 Some naming inspiration from rust-lang/rust-clippy#15092. There are several ways to go with this lint and I'm leaving the final decisions to the stabilization conversations. - Could be called `missing_lints` but that makes it sound like its needed even when there is no `workspace.lints` - The name implies it should lint for an empty `[lints]` - Naming to be specific enough is hard - We could lint on a `[lints]` without `workspace = true` but then they will have to turn this lint to `allow` when intentionally not inheriting, adding boilerplate, while we're mainly trying to cover the case of people thinking implicit inheritance is a thing.
143 lines
2.9 KiB
Rust
143 lines
2.9 KiB
Rust
use crate::prelude::*;
|
|
use cargo_test_support::project;
|
|
use cargo_test_support::str;
|
|
|
|
#[cargo_test]
|
|
fn default() {
|
|
let p = project()
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
edition = "2015"
|
|
authors = []
|
|
|
|
[lints.cargo]
|
|
this-lint-does-not-exist = "warn"
|
|
"#,
|
|
)
|
|
.file("src/lib.rs", "")
|
|
.build();
|
|
|
|
p.cargo("check -Zcargo-lints")
|
|
.masquerade_as_nightly_cargo(&["cargo-lints"])
|
|
.with_stderr_data(str![[r#"
|
|
[WARNING] unknown lint: `this-lint-does-not-exist`
|
|
--> Cargo.toml:9:1
|
|
|
|
|
9 | this-lint-does-not-exist = "warn"
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= [NOTE] `cargo::unknown_lints` is set to `warn` by default
|
|
[CHECKING] foo v0.0.1 ([ROOT]/foo)
|
|
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s
|
|
|
|
"#]])
|
|
.run();
|
|
}
|
|
|
|
#[cargo_test]
|
|
fn inherited() {
|
|
let p = project()
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[workspace]
|
|
members = ["foo"]
|
|
|
|
[workspace.lints.cargo]
|
|
this-lint-does-not-exist = "warn"
|
|
"#,
|
|
)
|
|
.file(
|
|
"foo/Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
edition = "2015"
|
|
authors = []
|
|
|
|
[lints]
|
|
workspace = true
|
|
"#,
|
|
)
|
|
.file("foo/src/lib.rs", "")
|
|
.build();
|
|
|
|
p.cargo("check -Zcargo-lints")
|
|
.masquerade_as_nightly_cargo(&["cargo-lints"])
|
|
.with_stderr_data(str![[r#"
|
|
[WARNING] unknown lint: `this-lint-does-not-exist`
|
|
--> Cargo.toml:6:1
|
|
|
|
|
6 | this-lint-does-not-exist = "warn"
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= [NOTE] `cargo::unknown_lints` is set to `warn` by default
|
|
[CHECKING] foo v0.0.1 ([ROOT]/foo/foo)
|
|
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s
|
|
|
|
"#]])
|
|
.run();
|
|
}
|
|
|
|
#[cargo_test]
|
|
fn not_inherited() {
|
|
let p = project()
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[workspace]
|
|
members = ["foo"]
|
|
|
|
[workspace.lints.cargo]
|
|
this-lint-does-not-exist = "warn"
|
|
"#,
|
|
)
|
|
.file(
|
|
"foo/Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
edition = "2015"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file("foo/src/lib.rs", "")
|
|
.build();
|
|
|
|
p.cargo("check -Zcargo-lints")
|
|
.masquerade_as_nightly_cargo(&["cargo-lints"])
|
|
.with_stderr_data(str![[r#"
|
|
[WARNING] unknown lint: `this-lint-does-not-exist`
|
|
--> Cargo.toml:6:1
|
|
|
|
|
6 | this-lint-does-not-exist = "warn"
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= [NOTE] `cargo::unknown_lints` is set to `warn` by default
|
|
[WARNING] missing `[lints]` to inherit `[workspace.lints]`
|
|
--> foo/Cargo.toml
|
|
= [NOTE] `cargo::missing_lints_inheritance` is set to `warn` by default
|
|
[HELP] to inherit `workspace.lints, add:
|
|
|
|
|
7 ~
|
|
8 + [lints]
|
|
9 + workspace = true
|
|
|
|
|
[HELP] to clarify your intent to not inherit, add:
|
|
|
|
|
7 ~
|
|
8 + [lints]
|
|
|
|
|
[CHECKING] foo v0.0.1 ([ROOT]/foo/foo)
|
|
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s
|
|
|
|
"#]])
|
|
.run();
|
|
}
|