bors 694a579566 Auto merge of #12349 - epage:sanitize, r=weihanglo ...

fix(embedded): Always generate valid package names

### What does this PR try to resolve?

The sanitization logic uses a placeholder for the first character that isn't valid in the first character position.  #12329 took the approach of always using `_` which has the problem of mixing separators if the user used `-` or we had other placeholders to insert.  Instead, this takes the approach of stripping the leading invalid characters and using a placeholder name if nothing is left.

Fixes #12330

### How should we test and review this PR?

Per-commit.  The first adds tests so the change in behavior can be observed over each additional commit.

### Additional information

I was also hoping to make the binary name not use placeholders by setting `bin.name` to `file_stem` but then I got
```
   Compiling s-h-w-c- v0.0.0 (/home/epage/src/personal/cargo/target/tmp/cit/t133/foo)
error: invalid character `'.'` in crate name: `s_h.w§c!`

error: invalid character `'§'` in crate name: `s_h.w§c!`

error: invalid character `'!'` in crate name: `s_h.w§c!`

error: could not compile `s-h-w-c-` (bin "s-h.w§c!") due to 3 previous errors
```
I decided to not get into what are or aren't valid characters according to rustc.

2023-07-11 22:28:29 +00:00

..

cargo_add

feat(cli): emit error when add is given a toolchain name instead of a crate name

2023-06-03 20:50:24 +07:00

cargo_new

Update cargo new workspace inheritance tests to specify resolver

2023-05-26 17:14:34 +02:00

cargo_remove

refactor(tests): Reduce cargo-remove setup load

2023-05-25 13:43:16 -05:00

init

Add a inherit test for init

2023-05-23 10:36:48 +08:00

mock-std

fix: hack around libsysroot instead of libtest

2023-05-05 14:48:37 +01:00

advanced_env.rs

Enable source_config_env test on Windows

2023-01-14 09:48:46 -08:00

alt_registry.rs

Added workspace_default_members to more tests.

2023-05-03 12:44:08 -07:00

artifact_dep.rs

Include rust-version in publish request

2023-04-26 11:59:29 -07:00

bad_config.rs

Auto merge of #12001 - hi-rustin:rustin-patch-dep-empty, r=weihanglo

2023-04-24 09:20:41 +00:00

bad_manifest_path.rs

chore: update bad_manifest_path test to use check

2023-02-15 15:28:48 -06:00

bench.rs

refactor(testsuite): Replace [project] with [package]

2022-09-26 09:51:16 -06:00

binary_name.rs

refactor(testsuite): Replace [project] with [package]

2022-09-26 09:51:16 -06:00

build_plan.rs

refactor(testsuite): Replace [project] with [package]

2022-09-26 09:51:16 -06:00

build_script_env.rs

Fix CARGO_CFG_ vars for configs defined both with and without value

2023-03-06 10:30:47 +01:00

build_script_extra_link_arg.rs

remove .masquerade_as_nightly_cargo() from build_script_extra_link_arg.rs

2022-07-14 15:05:33 -05:00

build_script.rs

Enable doctest-in-workspace by default

2023-06-17 19:34:34 +02:00

build.rs

Support "default" option for build.jobs

2023-06-03 15:24:41 +03:00

cache_messages.rs

chore: update cache_messages test to use check

2023-02-20 12:20:26 -06:00

cargo_alias_config.rs

chore: Update to toml v0.6, toml_edit v0.18

2023-01-19 15:26:28 -06:00

cargo_command.rs

add unit test for config and integration test with cargo --list

2023-03-09 16:54:01 -07:00

cargo_config.rs

add a reason to masquerade_as_nightly_cargo so it is searchable

2022-07-15 21:32:23 -05:00

cargo_env_config.rs

Disallow RUSTUP_TOOLCHAIN in the [env] table.

2023-05-08 09:30:59 -07:00

cargo_features.rs

Update tests for publish text changes

2023-03-15 08:50:11 -07:00

cargo_targets.rs

…

cfg.rs

chore: update cfg tests to use check

2023-02-20 12:20:26 -06:00

check_cfg.rs

chore: update check_cfg tests to use check

2023-02-20 12:20:26 -06:00

check.rs

Add rustc_shim_for_cargo_fix and wrapped_clippy_driver to reuse code

2023-04-14 11:23:41 +08:00

clean.rs

Run CI for macOS on nightly

2023-02-14 12:26:01 -08:00

collisions.rs

Fix collision_doc_profile test error

2022-12-15 20:04:50 -08:00

concurrent.rs

Re-enable killing_cargo_releases_the_lock on windows.

2022-08-02 12:30:42 -07:00

config_cli.rs

chore: Update to toml v0.6, toml_edit v0.18

2023-01-19 15:26:28 -06:00

config_include.rs

test(config-include): assert config merged in DFS

2023-06-21 20:18:09 +01:00

config.rs

Support "default" option for build.jobs

2023-06-03 15:24:41 +03:00

corrupt_git.rs

chore: update corrupt_git tests to use check

2023-02-20 12:20:46 -06:00

credential_process.rs

Stabilize cargo logout

2023-04-12 09:56:43 -07:00

cross_compile.rs

refactor: only when -C debuginfo > 0 will spilt-debuginfo be passed

2023-05-31 20:43:57 +01:00

cross_publish.rs

Reword published/completed to uploaded/published

2023-03-15 08:15:00 -07:00

custom_target.rs

Add requirements to cargo_test.

2022-07-30 19:36:58 -07:00

death.rs

chore: update death tests to use check

2023-02-20 12:21:15 -06:00

dep_info.rs

chore: update dep_info tests to use check

2023-02-20 12:21:15 -06:00

direct_minimal_versions.rs

feat(resolver): -Zdirect-minimal-versions

2023-02-14 15:44:30 -06:00

directory.rs

Add additional info on a new line

2023-06-05 11:27:31 +02:00

doc.rs

Enable doctest-in-workspace by default

2023-06-17 19:34:34 +02:00

docscrape.rs

fix(docscrape): must fail with bad build script

2023-02-09 20:32:24 +00:00

edition.rs

chore: update edition tests to use check

2023-02-20 12:21:15 -06:00

error.rs

…

features2.rs

Remove unnecessary warning line

2023-05-26 20:27:34 +02:00

features_namespaced.rs

Fix dep/feat syntax with hidden implicit optional dependencies

2023-05-11 09:34:38 -07:00

features.rs

Convert valid feature name warning to an error.

2023-06-20 12:39:27 -07:00

fetch.rs

…

fix.rs

Add rustc_shim_for_cargo_fix and wrapped_clippy_driver to reuse code

2023-04-14 11:23:41 +08:00

freshness.rs

fix: verify source before recompile

2023-02-03 14:17:34 +00:00

future_incompat_report.rs

chore: update future_incompat_report tests to use check

2023-02-20 12:21:27 -06:00

generate_lockfile.rs

Improve error for missing crate in --offline mode for sparse index

2023-03-01 14:45:09 -06:00

git_auth.rs

Add delays to network retries.

2023-03-31 14:04:48 -07:00

git_gc.rs

add -Zgitoxide=fetch feature toggle and implementation.

2023-03-02 12:35:50 +01:00

git_shallow.rs

Move helper functions to the bottom for consistency; fix name

2023-05-02 18:57:42 +02:00

git.rs

remove escapes and leading whitespace from string matches

2023-06-08 17:09:21 +00:00

glob_targets.rs

fix typos found by the typos-cli crate

2022-05-10 16:47:28 -05:00

help.rs

…

https.rs

Fix self_signed_should_fail for macOS.

2023-05-06 12:41:34 -07:00

inheritable_workspace_fields.rs

Include rust-version in publish request

2023-04-26 11:59:29 -07:00

install_upgrade.rs

chore: Update to toml v0.6, toml_edit v0.18

2023-01-19 15:26:28 -06:00

install.rs

Add additional info on a new line

2023-06-05 11:27:31 +02:00

jobserver.rs

chore: bump jobserver to respect --jobserver-auth=fifo:PATH'

2023-02-28 16:08:12 +00:00

lints.rs

fix(lints): Switch to -Zlints so stable projects can experiment

2023-05-22 13:45:20 -05:00

list_availables.rs

…

local_registry.rs

chore: update local_registry tests to use check

2023-02-20 12:21:27 -06:00

locate_project.rs

…

lockfile_compat.rs

-Znext-lockfile-bump: Don't suggest using -Z on stable

2023-06-22 11:55:42 -07:00

login.rs

Auto merge of #11949 - ehuss:logout-default, r=epage

2023-04-12 13:45:57 +00:00

logout.rs

Stabilize cargo logout

2023-04-12 09:56:43 -07:00

lto.rs

Disable test_profile test on windows-gnu

2023-03-30 19:18:10 -07:00

main.rs

feat(cli): Interpret some subcommands as manifest-commands

2023-06-08 20:17:03 -05:00

member_discovery.rs

refactor(testsuite): Replace [project] with [package]

2022-09-26 09:51:16 -06:00

member_errors.rs

refactor(testsuite): Replace [project] with [package]

2022-09-26 09:51:16 -06:00

message_format.rs

chore: update message_format tests to use check

2023-02-20 12:21:27 -06:00

messages.rs

Fixing issue https://github.com/rust-lang/cargo/issues/10834:

2023-03-07 06:45:26 +01:00

metabuild.rs

chore: update metabuild tests to use check

2023-02-20 12:21:27 -06:00

metadata.rs

Added workspace_default_members to more tests.

2023-05-03 12:44:08 -07:00

minimal_versions.rs

add a reason to masquerade_as_nightly_cargo so it is searchable

2022-07-15 21:32:23 -05:00

multitarget.rs

Update tests to reflect -Zmultitarget stabilization

2022-07-17 11:02:01 +01:00

net_config.rs

chore: update net_config tests to use check

2023-02-20 12:21:27 -06:00

new.rs

chore: fix target in generated hg ignore file

2023-03-15 16:39:24 +00:00

offline.rs

Assure that git-dependencies will get the correct storage, without ever unshallowing them.

2023-04-27 18:49:59 +02:00

old_cargos.rs

Add reasons to all ignored tests.

2022-08-02 12:24:00 -07:00

out_dir.rs

refactor(testsuite): Replace [project] with [package]

2022-09-26 09:51:16 -06:00

owner.rs

cleanups round 1

2022-12-13 23:49:07 +00:00

package_features.rs

chore: update package_features tests to use check

2023-02-20 12:21:27 -06:00

package.rs

Add test case for confilict README.md check

2023-05-14 16:55:23 +08:00

patch.rs

Enable shallow clones and fetches for registry and git dependencies.

2023-04-27 14:18:22 +02:00

path.rs

chore: update path tests to use check

2023-02-20 12:21:27 -06:00

paths.rs

chore: update paths tests to use check

2023-02-20 12:21:27 -06:00

pkgid.rs

fix some typos

2022-05-08 01:07:28 +08:00

plugins.rs

test: revive nightly plugin tests to work

2023-01-04 13:45:25 +00:00

proc_macro.rs

chore: update proc_macro tests to use check

2023-02-20 12:21:35 -06:00

profile_config.rs

refactor: only when -C debuginfo > 0 will spilt-debuginfo be passed

2023-05-31 20:43:57 +01:00

profile_custom.rs

Add reasons to all ignored tests.

2022-08-02 12:24:00 -07:00

profile_overrides.rs

chore: update profile_overrides tests to use check

2023-02-20 12:21:55 -06:00

profile_targets.rs

fix: should assert against stderr instead

2023-05-31 20:46:11 +01:00

profiles.rs

refactor: only when -C debuginfo > 0 will spilt-debuginfo be passed

2023-05-31 20:43:57 +01:00

progress.rs

chore: update progress tests to use check

2023-02-20 12:22:24 -06:00

pub_priv.rs

chore: update pub_priv tests to use check

2023-02-20 12:22:24 -06:00

publish_lockfile.rs

make test clearer

2022-12-19 10:50:55 -07:00

publish.rs

Include rust-version in publish request

2023-04-26 11:59:29 -07:00

read_manifest.rs

…

registry_auth.rs

Fix redacting tokens in http debug.

2023-05-06 12:41:06 -07:00

registry.rs

do not try an exponential number of package names

2023-05-05 17:15:06 +00:00

rename_deps.rs

refactor(testsuite): Replace [project] with [package]

2022-09-26 09:51:16 -06:00

replace.rs

chore: update replace tests to use check

2023-02-20 12:22:29 -06:00

required_features.rs

Add additional info on a new line

2023-06-05 11:27:31 +02:00

run.rs

refactor: only when -C debuginfo > 0 will spilt-debuginfo be passed

2023-05-31 20:43:57 +01:00

rust_version.rs

chore: update rust_version tests to use check

2023-02-20 12:22:29 -06:00

rustc_info_cache.rs

…

rustc.rs

refactor: only when -C debuginfo > 0 will spilt-debuginfo be passed

2023-05-31 20:43:57 +01:00

rustdoc_extern_html.rs

Make sparse the default protocol for crates.io

2023-03-02 10:50:22 -06:00

rustdoc.rs

…

rustdocflags.rs

Gleaning rustdocflags from target.cfg(…) is not supported

2022-11-01 15:01:44 +00:00

rustflags.rs

chore: update rustflags tests to use check

2023-02-20 12:22:29 -06:00

rustup.rs

Add an optimization when running under rustup.

2023-05-03 13:45:54 -07:00

script.rs

Auto merge of #12349 - epage:sanitize, r=weihanglo

2023-07-11 22:28:29 +00:00

search.rs

Implement RFC 3139: alternative registry authentication support

2022-11-16 14:36:19 -06:00

shell_quoting.rs

refactor(testsuite): Replace [project] with [package]

2022-09-26 09:51:16 -06:00

source_replacement.rs

Remove "up to 60 seconds" from waiting message.

2023-03-15 08:15:00 -07:00

ssh.rs

Update git2

2023-04-02 15:37:53 -07:00

standard_lib.rs

Add requirements to cargo_test.

2022-07-30 19:36:58 -07:00

test.rs

Simple explanations for why cargo rebuilds crates

2022-12-28 16:27:50 +01:00

timings.rs

Move timing reports to target/cargo-timings

2022-01-30 21:43:52 -08:00

tool_paths.rs

Fix test

2022-08-10 23:19:35 +08:00

tree_graph_features.rs

Do not ignore --features when --all-features is present

2022-01-28 02:49:42 +03:00

tree.rs

cargo-tree: Handle -e no-proc-macro when building the graph

2023-04-27 10:54:51 -07:00

unit_graph.rs

add a reason to masquerade_as_nightly_cargo so it is searchable

2022-07-15 21:32:23 -05:00

update.rs

Fixed test update::update_precise_first_run.

2023-05-03 13:08:51 -07:00

vendor.rs

Make sparse the default protocol for crates.io

2023-03-02 10:50:22 -06:00

verify_project.rs

add a reason to masquerade_as_nightly_cargo so it is searchable

2022-07-15 21:32:23 -05:00

version.rs

Re-enable version_works_without_rustc on windows.

2022-08-02 12:54:16 -07:00

warn_on_failure.rs

…

weak_dep_features.rs

Include rust-version in publish request

2023-04-26 11:59:29 -07:00

workspaces.rs

chore: update workspaces tests to use check

2023-02-20 12:22:29 -06:00

yank.rs

cleanups round 1

2022-12-13 23:49:07 +00:00