Alex Crichton 70dc4d8331 Don't use $CARGO_BUILD_TARGET in cargo metadata ...

This commit fixes a (five year old!) regression in `cargo metadata`
where if `--filter-platform` isn't explicitly specified it will
accidentally read `$CARGO_BUILD_TARGET` (or `build.target`
configuration) and use that as the default `--filter-platform`. The
reason for this is that the calculation for targets changed in #8167
and while the shared function makes sense for other commands such as
`cargo build` the targets have a different meaning in `cargo metadata`
so a slightly different set of functionality is desired.

This commit fixes the issue by introducing a new constructor for the
list of `CompileKind` variants where the fallback of "if nothing is
specified" is explicitly chosen.

2025-03-06 09:00:00 -08:00

..

cargo

feat: Add SBOM pre-cursor files

2025-02-26 14:57:14 -06:00

cargo_add

fix(add): Focus on error, rather than large feature lists

2025-02-18 12:44:13 -06:00

cargo_bench

cargo ... --help: clarify --tests and --benches

2024-10-12 16:30:20 +02:00

cargo_build

cargo ... --help: clarify --tests and --benches

2024-10-12 16:30:20 +02:00

cargo_check

cargo ... --help: clarify --tests and --benches

2024-10-12 16:30:20 +02:00

cargo_clean

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_config

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_doc

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_fetch

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_fix

Update autogenerated files

2025-01-04 14:37:39 +00:00

cargo_generate_lockfile

feat: Stabilize MSRV-aware resolver config

2024-10-04 12:49:28 -05:00

cargo_git_checkout

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

cargo_help

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_info

fix: Remove default registry reference in info cmd docs

2024-12-01 21:24:29 +08:00

cargo_init

test: requires attribute accepts string literals for cmds

2024-11-29 22:23:08 -05:00

cargo_install

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_locate_project

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_login

fix(login): Deprecate CLI token

2025-01-13 10:40:13 -06:00

cargo_logout

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_metadata

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_new

feat: Stabilize Edition 2024

2024-11-25 09:27:09 -06:00

cargo_owner

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_package

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_pkgid

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_publish

Support package selection in cargo publish

2024-10-10 09:37:10 +07:00

cargo_read_manifest

fix: make deprecated cmds more obvious in help and --list

2024-10-28 14:19:22 -04:00

cargo_remove

feat(toml): Allow adding/removing from cargo scripts

2024-11-26 12:23:48 -06:00

cargo_report

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_run

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_rustc

cargo ... --help: clarify --tests and --benches

2024-10-12 16:30:20 +02:00

cargo_rustdoc

cargo ... --help: clarify --tests and --benches

2024-10-12 16:30:20 +02:00

cargo_search

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_test

cargo ... --help: clarify --tests and --benches

2024-10-12 16:30:20 +02:00

cargo_tree

feat(tree): Color lines by dependency type

2025-02-28 09:46:50 -06:00

cargo_uninstall

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_update

feat: Stabilize MSRV-aware resolver config

2024-10-04 12:49:28 -05:00

cargo_vendor

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_verify_project

fix: make deprecated cmds more obvious in help and --list

2024-10-28 14:19:22 -04:00

cargo_version

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

cargo_yank

fix(help): mention --config <PATH> in help text

2024-10-01 14:54:52 -04:00

lints

Update annotate-snippets from 0.11.4 to 0.11.5

2025-02-09 12:46:36 -08:00

mock-std

test(build-std): make mock-std closer to real world

2024-12-05 10:50:51 -05:00

advanced_env.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

alt_registry.rs

Update annotate-snippets from 0.11.4 to 0.11.5

2025-02-09 12:46:36 -08:00

artifact_dep.rs

refactor: use manifest path as the key

2025-01-20 21:53:13 +08:00

artifact_dir.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

bad_config.rs

fix(schema): Mark package.name as optional

2025-02-10 14:29:15 -06:00

bad_manifest_path.rs

test: Migrate to pretty jsonlines for bad_manifest_path tests

2024-07-24 10:42:51 -05:00

bench.rs

test(bench): relax compiler panic assertions

2024-09-30 14:23:47 -04:00

binary_name.rs

test: make path arguments more generic and flexible

2024-12-24 10:33:21 -05:00

build_dir.rs

Seperated build directory from target directory

2025-02-25 21:05:23 +09:00

build_plan.rs

tests: Update for snapbox deprecations

2024-07-24 10:42:50 -05:00

build_script_env.rs

fix: envs in config can trigger rebuild by custom build script with rerun-if-env-changed.

2025-01-01 14:10:00 +08:00

build_script_extra_link_arg.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

build_script.rs

Update tests to deal with linker warnings

2025-01-26 13:25:17 -08:00

build.rs

feat: Make no target found hint more clear.

2025-02-28 10:03:59 +08:00

cache_lock.rs

feat(test): Add CargoPathExt to prelude

2024-07-18 15:22:29 -05:00

cache_messages.rs

test: Switch from 'exec_with_output' to 'run'

2024-11-21 13:48:27 -06:00

cargo_alias_config.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

cargo_command.rs

Move test to cargo_command.rs

2025-02-23 17:37:39 -05:00

cargo_env_config.rs

fix: trace [env] config table into fingerprint.

2024-10-25 11:21:52 +08:00

cargo_features.rs

Always include Cargo.lock in published crates

2024-11-14 09:06:18 +02:00

cargo_targets.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

cfg.rs

Adjust future-incompatibility cfg keyword with raw-idents in cfgs

2024-11-25 22:01:44 +01:00

check_cfg.rs

Revert "Conditionally mark the test cfg as a well known cfg (#15007)"

2025-02-01 14:14:05 -05:00

check.rs

feat: Stabilize Edition 2024

2024-11-25 09:27:09 -06:00

clean.rs

fix: Align new help messages with their error

2025-02-04 10:46:09 -06:00

collisions.rs

docs: Surround identifiers in backticks

2024-11-15 09:33:23 -06:00

concurrent.rs

fix(test): Move 'cargo_home' from 'install' to 'paths'

2024-07-19 10:50:42 -05:00

config_cli.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

config_include.rs

fix(fingerprint): Don't throwaway the cache on RUSTFLAGS changes

2024-12-05 16:11:11 -06:00

config.rs

fix(config): Don't merge unmergable config

2025-01-20 15:20:27 -06:00

corrupt_git.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

credential_process.rs

Don't suggest cargo login for other credential providers

2025-01-30 13:39:10 +00:00

cross_compile.rs

Update tests to deal with linker warnings

2025-01-26 13:25:17 -08:00

cross_publish.rs

feat(test): Snapshot .crate validation

2024-10-17 06:26:47 +08:00

custom_target.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

death.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

dep_info.rs

test: make path arguments more generic and flexible

2024-12-24 10:33:21 -05:00

diagnostics.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

direct_minimal_versions.rs

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

directory.rs

add unstable -Zroot-path flag to configure the path from which rustc should be invoked

2024-10-31 21:35:57 +01:00

doc.rs

fixed the error message for a user to open the crate

2024-12-20 03:46:16 +05:00

docscrape.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

edition.rs

test: Harden against 2027(?) edition

2024-11-27 13:10:32 -06:00

error.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

feature_unification.rs

feat: implement workspace feature unification

2025-02-11 15:10:39 +09:00

features2.rs

fix: mention "3" as a valid value for "resolver" field in error message

2025-02-21 21:46:22 +08:00

features_namespaced.rs

Suggest relevant feature names on the CLI

2025-02-04 18:33:15 +00:00

features.rs

fix: Remove implicit feature removal

2024-10-01 11:48:31 -05:00

fetch.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

fix_n_times.rs

docs: Surround identifiers in backticks

2024-11-15 09:33:23 -06:00

fix.rs

feat: add cargo pkgid support for cargo-script (#14961)

2025-02-04 19:52:07 +00:00

freshness_checksum.rs

Remove unused -C link-arg=-fuse-ld=lld

2025-01-24 11:44:49 -05:00

freshness.rs

Move test to cargo_command.rs

2025-02-23 17:37:39 -05:00

future_incompat_report.rs

test: Switch from 'exec_with_output' to 'run'

2024-11-21 13:48:27 -06:00

generate_lockfile.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

git_auth.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

git_gc.rs

test: requires attribute accepts string literals for cmds

2024-11-29 22:23:08 -05:00

git_shallow.rs

test(git): Be consistent on shallow test names

2024-12-18 15:44:01 -06:00

git.rs

util: provide a better error message for invalid SSH URLs

2025-02-14 19:43:16 +00:00

glob_targets.rs

test: migrate glob_targets to snapbox

2024-07-06 11:28:13 +08:00

global_cache_tracker.rs

test(gc): Update tests for latest stable

2025-02-20 15:47:19 -06:00

help.rs

fix: Align new help messages with their error

2025-02-04 10:46:09 -06:00

https.rs

Fix https::self_signed_should_fail for macos

2025-01-04 11:19:35 -08:00

inheritable_workspace_fields.rs

feat: Stabilize Edition 2024

2024-11-25 09:27:09 -06:00

install_upgrade.rs

fix(test): Move 'cargo_home' from 'install' to 'paths'

2024-07-19 10:50:42 -05:00

install.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

jobserver.rs

test(jobserver): relax compiler panic assertions

2024-09-30 13:25:33 -04:00

lints_table.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

list_availables.rs

refactor(test): make list_availables snapshot-aware

2024-07-14 04:09:34 +08:00

local_registry.rs

fix: use Registry::describe_source to fix error message and related test cases

2024-10-25 00:35:30 +08:00

locate_project.rs

tests: Update for snapbox deprecations

2024-07-24 10:42:50 -05:00

lockfile_compat.rs

feat: make lockfile v4 the default

2024-09-24 20:43:02 -04:00

lockfile_path.rs

feat: Stabilize Edition 2024

2024-11-25 09:27:09 -06:00

login.rs

fix(login): Deprecate CLI token

2025-01-13 10:40:13 -06:00

logout.rs

feat(test): Add CargoPathExt to prelude

2024-07-18 15:22:29 -05:00

lto.rs

test: Switch from 'exec_with_output' to 'run'

2024-11-21 13:48:27 -06:00

main.rs

test(tree): Group all cargo-tree tests

2025-02-28 09:18:07 -06:00

member_discovery.rs

fix(test): Move 'cargo_home' from 'install' to 'paths'

2024-07-19 10:50:42 -05:00

member_errors.rs

fix(test): Move 'cargo_home' from 'install' to 'paths'

2024-07-19 10:50:42 -05:00

message_format.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

messages.rs

test: migrate messages to snapbox

2024-07-26 23:26:48 +08:00

metabuild.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

metadata.rs

Don't use $CARGO_BUILD_TARGET in cargo metadata

2025-03-06 09:00:00 -08:00

minimal_versions.rs

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

multitarget.rs

test: migrate multitarget to snapbox

2024-07-09 08:03:09 +08:00

net_config.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

new.rs

test: requires attribute accepts string literals for cmds

2024-11-29 22:23:08 -05:00

offline.rs

fix(resolver): Consider --frozen, like --offline, in errors

2025-03-04 11:03:27 -06:00

old_cargos.rs

test: Migrate old_cargos to snapbox

2024-08-15 16:56:49 -05:00

open_namespaces.rs

feat: use full URL for embedded script paths

2025-01-20 21:53:15 +08:00

owner.rs

feat(test): Add CargoPathExt to prelude

2024-07-18 15:22:29 -05:00

package_features.rs

Suggest relevant feature names on the CLI

2025-02-04 18:33:15 +00:00

package.rs

refactor: control byte display precision with std::fmt options (#15246)

2025-02-28 14:32:42 +00:00

patch.rs

fix(base): Support bases in patches in virtual manifests

2024-12-13 11:00:57 -06:00

path.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

paths.rs

fix(resolve): Don't list transitive, incompatible dependencies as available

2024-09-19 11:42:33 -05:00

pgo.rs

fix(fingerprint): Don't throwaway the cache on RUSTFLAGS changes

2024-12-05 16:11:11 -06:00

pkgid.rs

fix: Align new help messages with their error

2025-02-04 10:46:09 -06:00

precise_pre_release.rs

test: Ensure we don't rely on unit return values

2024-11-18 20:52:53 -06:00

proc_macro.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

profile_config.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

profile_custom.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

profile_overrides.rs

fix: Align new help messages with their error

2025-02-04 10:46:09 -06:00

profile_targets.rs

feat(rustdoc): diplay env vars in extra verbose mode

2024-11-12 22:57:45 -05:00

profile_trim_paths.rs

test: requires attribute accepts string literals for cmds

2024-11-29 22:23:08 -05:00

profiles.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

progress.rs

refactor: control byte display precision with std::fmt options

2025-02-28 08:56:28 -05:00

pub_priv.rs

test: Ensure we don't rely on unit return values

2024-11-18 20:52:53 -06:00

publish_lockfile.rs

refactor(cargo-package): let-else to flatten code

2024-12-19 08:37:24 -05:00

publish.rs

fix: Align new help messages with their error

2025-02-04 10:46:09 -06:00

read_manifest.rs

tests: Update for snapbox deprecations

2024-07-24 10:42:50 -05:00

registry_auth.rs

test: Switch from 'exec_with_output' to 'run'

2024-11-21 13:48:27 -06:00

registry_overlay.rs

test: switch to unordered assertions

2024-11-23 10:20:59 -05:00

registry.rs

fix(registry): Respect --frozen like --offline

2025-03-04 11:03:27 -06:00

rename_deps.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

replace.rs

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

required_features.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

run.rs

feat: Make no target found hint more clear.

2025-02-28 10:03:59 +08:00

rust_version.rs

feat: Stabilize Edition 2024

2024-11-25 09:27:09 -06:00

rustc_info_cache.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

rustc.rs

Setup cargo environment for cargo rustc --print (#15026)

2025-01-07 18:39:52 +00:00

rustdoc_extern_html.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

rustdoc.rs

fix(cargo-rustc): stabilize higher precedence trailing flags

2024-12-18 09:30:17 -05:00

rustdocflags.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

rustflags.rs

fix(fingerprint): Hackily keep --remap-path-prefix binaries reproducible

2024-12-05 16:30:09 -06:00

rustup.rs

feat(test): Add CargoPathExt to prelude

2024-07-18 15:22:29 -05:00

sbom.rs

feat: Add SBOM pre-cursor files

2025-02-26 14:57:14 -06:00

script.rs

fix(package): Ensure we can package directories ending with '.rs'

2025-02-27 14:50:56 -06:00

search.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

shell_quoting.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

source_replacement.rs

Always include Cargo.lock in published crates

2024-11-14 09:06:18 +02:00

ssh.rs

docs: Surround identifiers in backticks

2024-11-15 09:33:23 -06:00

standard_lib.rs

Fix shared_std_dependency_rebuild running on Windows

2025-01-27 19:06:22 -08:00

test.rs

fix: reset $CARGO if the running program is real cargo[.exe] (#15208)

2025-02-28 15:04:52 +00:00

timings.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

tool_paths.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

unit_graph.rs

tests: Update for snapbox deprecations

2024-07-24 10:42:50 -05:00

update.rs

fix: use Registry::describe_source to fix error message and related test cases

2024-10-25 00:35:30 +08:00

vendor.rs

fix(vendor): dont remove non-cached source

2025-03-03 20:47:44 -05:00

verify_project.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

version.rs

refactor: Migrate from extern crate to test-support prelude

2024-07-12 15:57:00 -05:00

warn_on_failure.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

warning_override.rs

feat: add build.warnings config option to control rustc warnings

2024-11-08 15:27:33 -06:00

weak_dep_features.rs

refactor(schema): Group TomlManifest fields to clarify requires_package

2024-12-13 10:31:53 -06:00

workspaces.rs

feat: Make no target found hint more clear.

2025-02-28 10:03:59 +08:00

yank.rs

feat(test): Add CargoPathExt to prelude

2024-07-18 15:22:29 -05:00