mirror of
https://github.com/rust-lang/cargo.git
synced 2025-09-28 11:20:36 +00:00
7e2a3c21e0
fix(toml): Add `default-features` to `TomlWorkspaceDependency` In #11329 it was noted that `default-features` is ignored when used in a dependency that inherits from a workspace i.e. ```toml [workspace] members = [] [workspace.dependencies] dep = "0.1" [package] name = "bar" version = "0.2.0" authors = [] [dependencies] dep = { workspace = true, default-features = false } ``` This problem is caused by problems with deserializing a `TomlDependency` and not emitting an unused manifest key correctly. When discussed in a recent Cargo team meeting we felt the best course of action was to allow `default-features = false` when inheriting a dependency, but it does not change actually set `default-features`. It will be used to warn when there is a difference between the definition in `[workspace.dependencies]` and `[dependencies]` i.e. ```toml [package] name = "bar" version = "0.2.0" [dependencies] dep = { workspace = true, default-features = false } [workspace] members = [] [workspace.dependencies] dep = { version = "0.1", default-features = true } ``` This does not entirely resolve the problem with unused manifest keys. A follow up PR and issue will be created to address those concerns. close #11329