cargo

mirror of https://github.com/rust-lang/cargo.git synced 2025-09-28 11:20:36 +00:00

History

bors c26943919a Auto merge of #12837 - epage:remove, r=weihanglo

fix(remove): Preserve feature comments

### What does this PR try to resolve?

We've been having a hard time balancing leaving the feature list in a good looking start and preserving formatting.  With our new formatting policy (#12836), we can just choose to preserve formatting instead.

Fixes #11743

### How should we test and review this PR?

The first commit copies an existing test.  The second is where the fun begins, customizing the test for some weird cases.  The follow up commits do the slow walk for improving it.

We ended up preserving some line-trailing comments because they come after the comma and toml_edit treats that as part of the prefix of the next item.  Tracking removal of that was going to require us to determine if the newline existed in the suffix or in the next item's prefix and edit accordingly and I decided to skip that to keep this initial implementation simpler.

### Additional information

2023-10-19 15:36:20 +00:00

cargo

fix(help): Provide better commands heading for styling

2023-08-29 15:31:17 -05:00

cargo_add

fix(add): Add back in some auto-formatting

2023-10-17 12:48:45 -05:00

cargo_bench

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

cargo_build

refactor(cli): Manually implement missing arg error for --target

2023-08-30 20:42:45 -05:00

cargo_check

refactor(cli): Manually implement missing arg error for --target

2023-08-30 20:42:45 -05:00

cargo_clean

Add a --dry-run option to cargo clean.

2023-09-19 18:14:47 -07:00

cargo_config

Merge higher precedence config lists later

2023-08-16 11:21:38 -05:00

cargo_doc

refactor(cli): Manually implement missing arg error for --target

2023-08-30 20:42:45 -05:00

cargo_fetch

refactor(cli): Manually implement missing arg error for --target

2023-08-30 20:42:45 -05:00

cargo_fix

refactor(cli): Manually implement missing arg error for --target

2023-08-30 20:42:45 -05:00

cargo_generate_lockfile

fix(cli): Make --help easier to browse

2023-08-08 13:50:05 -05:00

cargo_git_checkout

test(cli): Track --help output

2023-07-24 17:12:20 -05:00

cargo_help

fix(cli): Make --help easier to browse

2023-08-08 13:50:05 -05:00

cargo_init

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

cargo_install

fix(help): Clarify install's positional

2023-10-17 16:48:15 -05:00

cargo_locate_project

fix(cli): Make --help easier to browse

2023-08-08 13:50:05 -05:00

cargo_login

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

cargo_logout

fix(cli): Make --help easier to browse

2023-08-08 13:50:05 -05:00

cargo_metadata

fix(cli): Make --help easier to browse

2023-08-08 13:50:05 -05:00

cargo_new

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

cargo_owner

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

cargo_package

refactor(cli): Manually implement missing arg error for --target

2023-08-30 20:42:45 -05:00

cargo_pkgid

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

cargo_publish

Auto merge of #12660 - epage:dry, r=weihanglo

2023-09-18 02:53:19 +00:00

cargo_read_manifest

fix(cli): Make --help easier to browse

2023-08-08 13:50:05 -05:00

cargo_remove

fix(remove): Carry comments across removes

2023-10-17 11:56:54 -05:00

cargo_report

fix(cli): Make --help easier to browse

2023-08-08 13:50:05 -05:00

cargo_run

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

cargo_rustc

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

cargo_rustdoc

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

cargo_search

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

cargo_test

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

cargo_tree

refactor(cli): Manually implement missing arg error for --target

2023-08-30 20:42:45 -05:00

cargo_uninstall

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

cargo_update

feat(cli): Add '-n' to dry-run

2023-09-12 13:42:00 -05:00

cargo_vendor

fix(cli): Make --help easier to browse

2023-08-08 13:50:05 -05:00

cargo_verify_project

fix(cli): Make --help easier to browse

2023-08-08 13:50:05 -05:00

cargo_version

fix(cli): Make --help easier to browse

2023-08-08 13:50:05 -05:00

cargo_yank

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

mock-std

…

advanced_env.rs

…

alt_registry.rs

refactor: --registry always conflicts with --index

2023-09-15 22:33:27 +08:00

artifact_dep.rs

apply suggestions

2023-08-25 01:43:29 +00:00

bad_config.rs

fix(manifest): Provide more context on sematic errors

2023-08-24 16:27:53 -05:00

bad_manifest_path.rs

…

bench.rs

test: move --keep-going suggestion match tests to UI tests

2023-08-22 19:21:09 +01:00

binary_name.rs

…

build_plan.rs

…

build_script_env.rs

Print environment variables for build script executions with -vv

2023-10-15 19:50:11 +02:00

build_script_extra_link_arg.rs

feat: add package name and version to warning messages

2023-10-11 16:52:30 -03:00

build_script.rs

feat: add package name and version to warning messages

2023-10-11 16:52:30 -03:00

build.rs

Better suggestion for unsupported -path flag

2023-10-12 19:24:42 +08:00

cache_lock.rs

Rewrite the cache locker to use functions instead of macros.

2023-10-08 14:16:51 -07:00

cache_messages.rs

…

cargo_alias_config.rs

fix(toml): Remove redundant error messages

2023-08-24 16:19:48 -05:00

cargo_command.rs

fix(cli): Suggest cargo-search on bad commands

2023-10-17 14:46:30 -05:00

cargo_env_config.rs

…

cargo_features.rs

fix(manifest): Provide more context on sematic errors

2023-08-24 16:27:53 -05:00

cargo_targets.rs

…

cfg.rs

…

check_cfg.rs

Adjust -Zcheck-cfg for new rustc syntax and behavior

2023-10-18 15:10:25 +02:00

check.rs

Stabilize --keep-going

2023-08-26 13:14:39 -07:00

clean.rs

Don't display paths with cargo clean --dry-run without --verbose

2023-09-19 18:24:45 -07:00

collisions.rs

…

concurrent.rs

…

config_cli.rs

Merge higher precedence config lists later

2023-08-16 11:21:38 -05:00

config_include.rs

test(config-include): assert config merged in DFS

2023-06-21 20:18:09 +01:00

config.rs

Add ConfigBuilder::root

2023-10-08 14:16:51 -07:00

corrupt_git.rs

…

credential_process.rs

chore: Fix typos

2023-09-19 15:28:48 -05:00

cross_compile.rs

…

cross_publish.rs

…

custom_target.rs

Disable custom_target::custom_bin_target on windows-gnu

2023-10-01 19:14:46 -07:00

death.rs

bug: corruption when killed while writing

2023-10-01 08:29:24 -04:00

dep_info.rs

…

direct_minimal_versions.rs

…

directory.rs

…

doc.rs

rustdoc: remove the word "Version" from test cases

2023-10-10 11:19:57 -07:00

docscrape.rs

…

edition.rs

…

error.rs

…

features2.rs

feat: add package name and version to warning messages

2023-10-11 16:52:30 -03:00

features_namespaced.rs

…

features.rs

Convert valid feature name warning to an error.

2023-06-20 12:39:27 -07:00

fetch.rs

…

fix.rs

…

freshness.rs

chore: Fix typos

2023-09-19 15:28:48 -05:00

future_incompat_report.rs

fix(update): Make -p more convenient by being positional

2023-08-23 11:57:36 -05:00

generate_lockfile.rs

…

git_auth.rs

…

git_gc.rs

…

git_shallow.rs

…

git.rs

generalise suggestion on abiguous spec

2023-09-18 16:34:17 +01:00

glob_targets.rs

…

help.rs

…

https.rs

…

inheritable_workspace_fields.rs

fix(manifest): Provide more context on sematic errors

2023-08-24 16:27:53 -05:00

install_upgrade.rs

fix(pkgid): More consistently refer to SemVer

2023-08-29 10:49:09 -05:00

install.rs

fix(help): Clarify install's positional

2023-10-17 16:48:15 -05:00

jobserver.rs

…

lints.rs

feat: Stabilize lints

2023-09-08 10:44:00 -05:00

list_availables.rs

fix(cli): Be more specific in what is needed

2023-08-31 08:56:16 -05:00

local_registry.rs

…

locate_project.rs

…

lockfile_compat.rs

Auto merge of #12280 - weihanglo:git-ref-ambiguity, r=ehuss

2023-07-23 19:01:50 +00:00

feat: stabilize credential-process and registry-auth

2023-09-16 22:40:45 -05:00

logout.rs

Auto merge of #12588 - arlosi:logout-is-stable, r=weihanglo

2023-08-29 18:17:10 +00:00

lto.rs

Ues strip_prefix for cleaner code

2023-09-07 17:57:28 +00:00

main.rs

Add a new package cache locking system.

2023-10-08 14:16:51 -07:00

member_discovery.rs

…

member_errors.rs

…

message_format.rs

…

messages.rs

…

metabuild.rs

…

metadata.rs

fix(manifest): Provide more context on sematic errors

2023-08-24 16:27:53 -05:00

minimal_versions.rs

…

multitarget.rs

…

net_config.rs

…

new.rs

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

offline.rs

fix(update): Make -p more convenient by being positional

2023-08-23 11:57:36 -05:00

old_cargos.rs

…

out_dir.rs

Add unsupported short suggestion for --out-dir flag

2023-10-04 13:15:09 +08:00

owner.rs

Create dedicated unstable flag for asymmetric-token

2023-08-24 00:12:50 -05:00

package_features.rs

…

package.rs

feat: Add Edition2024

2023-10-04 13:11:52 -06:00

patch.rs

move pre-release specific error message

2023-09-12 16:06:29 +00:00

path.rs

…

paths.rs

…

pkgid.rs

generalise suggestion on abiguous spec

2023-09-18 16:34:17 +01:00

plugins.rs

…

proc_macro.rs

…

profile_config.rs

chore: Fix typos

2023-09-19 15:28:48 -05:00

profile_custom.rs

Separately track files and directories removed.

2023-09-19 18:24:37 -07:00

profile_overrides.rs

feat(spec): Allow partial versions when unambigious

2023-09-13 22:00:00 -06:00

profile_targets.rs

Print environment variables for cargo test in extra verbose mode

2023-08-16 13:41:54 +02:00

profiles.rs

test: new options of debuginfo are no longer unstable

2023-09-01 16:19:47 +01:00

progress.rs

…

pub_priv.rs

Support public dependency configuration with workspace deps

2023-10-13 00:32:05 -07:00

publish_lockfile.rs

…

publish.rs

Fix spurious errors with networking tests.

2023-09-22 13:37:26 -07:00

read_manifest.rs

…

registry_auth.rs

feat: stabilize credential-process and registry-auth

2023-09-16 22:40:45 -05:00

registry.rs

move pre-release specific error message

2023-09-12 16:06:29 +00:00

rename_deps.rs

…

replace.rs

test(replace): Clarify name for remaining new test

2023-10-17 10:09:45 -05:00

required_features.rs

…

run.rs

fix(help): Consistently use SCREAMING_CASE for value names

2023-10-17 16:47:44 -05:00

rust_version.rs

fix(manifest): Improve error on good pre-release

2023-08-30 16:42:08 -05:00

rustc_info_cache.rs

…

rustc.rs

…

rustdoc_extern_html.rs

…

rustdoc.rs

…

rustdocflags.rs

rustdoc: remove the word "Version" from test cases

2023-10-10 11:19:57 -07:00

rustflags.rs

…

rustup.rs

…

script.rs

fix(cli): Suggest cargo-search on bad commands

2023-10-17 14:46:30 -05:00

search.rs

Add a new package cache locking system.

2023-10-08 14:16:51 -07:00

shell_quoting.rs

…

source_replacement.rs

Auto merge of #12732 - tompscanlan:12576-registry-error-msg, r=epage

2023-09-25 17:41:03 +00:00

ssh.rs

add a missing is:

2023-09-08 15:14:10 -04:00

standard_lib.rs

…

test.rs

test: move --keep-going suggestion match tests to UI tests

2023-08-22 19:21:09 +01:00

timings.rs

…

tool_paths.rs

Add some tests

2023-08-28 09:29:17 +08:00

tree_graph_features.rs

…

tree.rs

generalise suggestion on abiguous spec

2023-09-18 16:34:17 +01:00

unit_graph.rs

…

update.rs

Do not call it "Downgrading" when difference is only build metadata

2023-10-09 13:53:47 -07:00

vendor.rs

fix: respect umask when unpacking .crate files

2023-08-03 13:41:08 +01:00

verify_project.rs

…

version.rs

Add test for -V short argument

2023-10-14 23:16:11 +08:00

warn_on_failure.rs

feat: add package name and version to warning messages

2023-10-11 16:52:30 -03:00

weak_dep_features.rs

…

workspaces.rs

fix(toml): Remove redundant error messages

2023-08-24 16:19:48 -05:00

yank.rs

Create dedicated unstable flag for asymmetric-token

2023-08-24 00:12:50 -05:00