Weihang Lo c3409d5425

refactor: clean up clippy::perf lint warnings ...

The `clippy::perf` lint group is fairly useful for catching bad
practices that might hurt performance marginally.

This PR fixes most of them except `clippy::large_enum_variant`,
which doesn't feel right at this moment and need more researches.

Anyway, overall this PR should be good.

2025-06-04 14:23:12 -07:00

..

cargo

Add the -Zfix-edition flag

2025-05-25 08:18:41 -07:00

cargo_add

Fix cargo add overwriting symlinked Cargo.toml files (#15281)

2025-06-02 10:23:52 +00:00

cargo_bench

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_build

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_check

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_clean

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_config

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_doc

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_fetch

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_fix

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_generate_lockfile

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_git_checkout

…

cargo_help

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_info

Prevent undeclared public network access

2025-04-01 11:41:30 +02:00

cargo_init

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_install

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_locate_project

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_login

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_logout

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_metadata

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_new

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_owner

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_package

feat(package): add unstable --message-format flag

2025-03-25 23:02:37 -04:00

cargo_pkgid

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_publish

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_read_manifest

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_remove

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_report

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_run

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_rustc

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_rustdoc

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_search

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_test

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_tree

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_uninstall

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_update

Update dependencies

2025-05-17 19:32:32 -07:00

cargo_vendor

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_verify_project

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_version

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

cargo_yank

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

lints

Update annotate-snippets from 0.11.4 to 0.11.5

2025-02-09 12:46:36 -08:00

mock-std

test(build-std): make mock-std closer to real world

2024-12-05 10:50:51 -05:00

advanced_env.rs

…

alt_registry.rs

Update annotate-snippets from 0.11.4 to 0.11.5

2025-02-09 12:46:36 -08:00

artifact_dep.rs

Stabilize doctest-xcompile

2025-05-14 08:52:27 -07:00

artifact_dir.rs

…

bad_config.rs

fix(schema): Mark package.name as optional

2025-02-10 14:29:15 -06:00

bad_manifest_path.rs

…

bench.rs

test(bench): relax compiler panic assertions

2024-09-30 14:23:47 -04:00

binary_name.rs

test: make path arguments more generic and flexible

2024-12-24 10:33:21 -05:00

build_dir.rs

feat(build-dir): Added improved error message when template is invalid

2025-04-12 02:20:15 +09:00

build_plan.rs

…

build_script_env.rs

fix: envs in config can trigger rebuild by custom build script with rerun-if-env-changed.

2025-01-01 14:10:00 +08:00

build_script_extra_link_arg.rs

do not pass cdylib link args to test

2025-03-19 20:20:45 +08:00

build_script.rs

Stabilize doctest-xcompile

2025-05-14 08:52:27 -07:00

build.rs

refactor: separate "global" mode from CompileMode

2025-05-27 11:48:30 -04:00

cache_lock.rs

…

cache_messages.rs

test: Switch from 'exec_with_output' to 'run'

2024-11-21 13:48:27 -06:00

cargo_alias_config.rs

…

cargo_command.rs

Don't canonicalize in cargo_exe

2025-03-26 23:47:08 +00:00

cargo_env_config.rs

fix: trace [env] config table into fingerprint.

2024-10-25 11:21:52 +08:00

cargo_features.rs

Always include Cargo.lock in published crates

2024-11-14 09:06:18 +02:00

cargo_targets.rs

…

cfg.rs

Add support for boolean literals in target cfgs

2025-04-22 19:23:03 +02:00

check_cfg.rs

Revert "Conditionally mark the test cfg as a well known cfg (#15007)"

2025-02-01 14:14:05 -05:00

check.rs

feat: Stabilize Edition 2024

2024-11-25 09:27:09 -06:00

clean.rs

fix: Align new help messages with their error

2025-02-04 10:46:09 -06:00

collisions.rs

docs: Surround identifiers in backticks

2024-11-15 09:33:23 -06:00

concurrent.rs

…

config_cli.rs

…

config_include.rs

fix(fingerprint): Don't throwaway the cache on RUSTFLAGS changes

2024-12-05 16:11:11 -06:00

config.rs

fix(config): Don't merge unmergable config

2025-01-20 15:20:27 -06:00

corrupt_git.rs

…

credential_process.rs

Don't suggest cargo login for other credential providers

2025-01-30 13:39:10 +00:00

cross_compile.rs

Stabilize doctest-xcompile

2025-05-14 08:52:27 -07:00

cross_publish.rs

feat(test): Snapshot .crate validation

2024-10-17 06:26:47 +08:00

custom_target.rs

Stabilize doctest-xcompile

2025-05-14 08:52:27 -07:00

death.rs

…

dep_info.rs

test: make path arguments more generic and flexible

2024-12-24 10:33:21 -05:00

diagnostics.rs

…

direct_minimal_versions.rs

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

directory.rs

add unstable -Zroot-path flag to configure the path from which rustc should be invoked

2024-10-31 21:35:57 +01:00

doc.rs

feat(fingerprint): integrate rustdoc dep-info files

2025-03-28 22:07:30 -07:00

docscrape.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

edition.rs

Add the future edition

2025-05-24 17:36:32 -07:00

error.rs

…

feature_unification.rs

feat: implement workspace feature unification

2025-02-11 15:10:39 +09:00

features2.rs

fix: mention "3" as a valid value for "resolver" field in error message

2025-02-21 21:46:22 +08:00

features_namespaced.rs

fix(resolver): Have errors follow rustc's casing convention

2025-04-24 20:40:54 -05:00

features.rs

fix(resolver): Suggest similar looking features

2025-04-25 09:21:09 -05:00

fetch.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

fix_n_times.rs

docs: Surround identifiers in backticks

2024-11-15 09:33:23 -06:00

fix.rs

Implement -Zfix-edition

2025-05-25 08:24:09 -07:00

freshness_checksum.rs

fix(toml): Report '<target>.edition' deprecation to users

2025-03-15 03:04:18 -05:00

freshness.rs

fix(toml): Report '<target>.edition' deprecation to users

2025-03-15 03:04:18 -05:00

future_incompat_report.rs

Remove an excess newline

2025-03-21 16:32:28 -07:00

generate_lockfile.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

git_auth.rs

fix the odd info '1 tries remaining'

2025-04-28 13:29:27 +08:00

git_gc.rs

test: requires attribute accepts string literals for cmds

2024-11-29 22:23:08 -05:00

git_shallow.rs

test(git): Be consistent on shallow test names

2024-12-18 15:44:01 -06:00

git.rs

refactor: clean up clippy::perf lint warnings

2025-06-04 14:23:12 -07:00

glob_targets.rs

…

global_cache_tracker.rs

Stabilize automatic garbage collection.

2025-03-31 09:28:44 -07:00

help.rs

fix: Align new help messages with their error

2025-02-04 10:46:09 -06:00

https.rs

Fix https::self_signed_should_fail for macos

2025-01-04 11:19:35 -08:00

inheritable_workspace_fields.rs

refactor: clean up clippy::perf lint warnings

2025-06-04 14:23:12 -07:00

install_upgrade.rs

…

install.rs

refactor: clean up clippy::perf lint warnings

2025-06-04 14:23:12 -07:00

jobserver.rs

test(jobserver): relax compiler panic assertions

2024-09-30 13:25:33 -04:00

lints_table.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

list_availables.rs

…

local_registry.rs

fix: use Registry::describe_source to fix error message and related test cases

2024-10-25 00:35:30 +08:00

locate_project.rs

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

lockfile_compat.rs

feat: make lockfile v4 the default

2024-09-24 20:43:02 -04:00

lockfile_path.rs

fix(toml): Remove workaround for rustc frontmatter support

2025-05-21 12:48:56 -05:00

login.rs

fix(login): Deprecate CLI token

2025-01-13 10:40:13 -06:00

logout.rs

…

lto.rs

test: Switch from 'exec_with_output' to 'run'

2024-11-21 13:48:27 -06:00

main.rs

feat(package): add unstable --message-format flag

2025-03-25 23:02:37 -04:00

member_discovery.rs

…

member_errors.rs

refactor: separate "global" mode from CompileMode

2025-05-27 11:48:30 -04:00

message_format.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

messages.rs

…

metabuild.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

metadata.rs

feat(build-dir): Added build-directory to cargo metadata output

2025-04-02 21:38:35 +09:00

minimal_versions.rs

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

multitarget.rs

…

net_config.rs

fix the odd info '1 tries remaining'

2025-04-28 13:29:27 +08:00

new.rs

test: Remove unused nightly requirements

2025-05-06 12:52:20 -05:00

offline.rs

fix(resolver): Consider --frozen, like --offline, in errors

2025-03-04 11:03:27 -06:00

old_cargos.rs

test: Migrate old_cargos to snapbox

2024-08-15 16:56:49 -05:00

open_namespaces.rs

fix(toml): Remove workaround for rustc frontmatter support

2025-05-21 12:48:56 -05:00

owner.rs

…

package_features.rs

fix(resolver): Have errors follow rustc's casing convention

2025-04-24 20:40:54 -05:00

package_message_format.rs

fix(package): update tracking issue for --message-format

2025-03-26 13:37:01 -04:00

package.rs

refactor: clean up clippy::perf lint warnings

2025-06-04 14:23:12 -07:00

patch.rs

fix(base): Support bases in patches in virtual manifests

2024-12-13 11:00:57 -06:00

path.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

paths.rs

fix(resolve): Don't list transitive, incompatible dependencies as available

2024-09-19 11:42:33 -05:00

pgo.rs

fix(fingerprint): Don't throwaway the cache on RUSTFLAGS changes

2024-12-05 16:11:11 -06:00

pkgid.rs

fix: Align new help messages with their error

2025-02-04 10:46:09 -06:00

precise_pre_release.rs

test: Ensure we don't rely on unit return values

2024-11-18 20:52:53 -06:00

proc_macro.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

profile_config.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

profile_custom.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

profile_overrides.rs

fix: Align new help messages with their error

2025-02-04 10:46:09 -06:00

profile_targets.rs

feat(rustdoc): diplay env vars in extra verbose mode

2024-11-12 22:57:45 -05:00

profile_trim_paths.rs

fix(trim-paths): remap all paths to build.build-dir

2025-06-02 14:26:36 -04:00

profiles.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

progress.rs

feat: use default value for term.progress

2025-03-09 23:20:11 +03:00

pub_priv.rs

test: Ensure we don't rely on unit return values

2024-11-18 20:52:53 -06:00

publish_lockfile.rs

refactor(cargo-package): let-else to flatten code

2024-12-19 08:37:24 -05:00

publish.rs

fix(publish): better message when nothing to publish

2025-05-14 01:22:30 -04:00

read_manifest.rs

…

registry_auth.rs

test: Switch from 'exec_with_output' to 'run'

2024-11-21 13:48:27 -06:00

registry_overlay.rs

test: switch to unordered assertions

2024-11-23 10:20:59 -05:00

registry.rs

feat(network): use Retry-After header for HTTP 429 responses

2025-05-07 15:44:35 -05:00

rename_deps.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

replace.rs

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

required_features.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

run.rs

fix(run): Say what the multiple executables are

2025-03-11 13:15:54 -05:00

rust_version.rs

feat: Stabilize Edition 2024

2024-11-25 09:27:09 -06:00

rustc_info_cache.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

rustc.rs

fix(rustc): Don't panic on unknown bins

2025-05-06 11:13:30 -05:00

rustdoc_extern_html.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

rustdoc.rs

fix(cargo-rustc): stabilize higher precedence trailing flags

2024-12-18 09:30:17 -05:00

rustdocflags.rs

…

rustflags.rs

fix(fingerprint): Hackily keep --remap-path-prefix binaries reproducible

2024-12-05 16:30:09 -06:00

rustup.rs

…

sbom.rs

feat: Add SBOM pre-cursor files

2025-02-26 14:57:14 -06:00

script.rs

fix(toml): Remove workaround for rustc frontmatter support

2025-05-21 12:48:56 -05:00

search.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

shell_quoting.rs

…

source_replacement.rs

Always include Cargo.lock in published crates

2024-11-14 09:06:18 +02:00

ssh.rs

docs: Surround identifiers in backticks

2024-11-15 09:33:23 -06:00

standard_lib.rs

fix: remove unnecessary workaround in standard_lib test (#15522)

2025-05-20 11:45:38 +00:00

test.rs

test(test): ensure panic=abort not added to default example inclusion

2025-05-29 20:45:47 -04:00

timings.rs

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

tool_paths.rs

…

unit_graph.rs

fully fixes #15445

2025-04-23 13:19:45 +02:00

update.rs

refactor: clean up clippy::perf lint warnings

2025-06-04 14:23:12 -07:00

vendor.rs

fix(vendor)!: vendor files with .rej/.orig suffix

2025-05-21 13:17:16 -04:00

verify_project.rs

…

version.rs

…

warn_on_failure.rs

fix(test): Un-deprecate contains assertions

2024-11-07 15:55:35 -06:00

warning_override.rs

feat: add build.warnings config option to control rustc warnings

2024-11-08 15:27:33 -06:00

weak_dep_features.rs

refactor(schema): Group TomlManifest fields to clarify requires_package

2024-12-13 10:31:53 -06:00

workspaces.rs

test(run): Move run-focused test with rest

2025-03-11 11:07:39 -05:00

yank.rs

yank: Check for bad version & added error message for prefixed v in version

2025-05-03 22:31:08 +05:30