Weihang Lo d7940042bd

Fix cargo add overwriting symlinked Cargo.toml files (#15281) ...

### What does this PR try to resolve?

This PR fixes a bug where `cargo add` breaks symlinks to Cargo.toml
files. Currently, when Cargo.toml is a symlink and `cargo add` is used
to add a dependency, the symlink is replaced with a regular file,
breaking the link to the original target file.

This issue was reported in #15241 where a user who relies on symlinked
Cargo.toml files found that `cargo add` breaks their workflow.

Fixes #15241

### How should we test and review this PR?

I've modified `LocalManifest::write()` to check if the path is a
symlink, and if so, follow it to get the actual target path. This
ensures we write to the actual file rather than replacing the symlink.

I've also added a test in `tests/testsuite/cargo_add/symlink.rs` that:
1. Creates a symlinked Cargo.toml file
2. Runs `cargo add` to add a dependency
3. Verifies the symlink is preserved and the dependency is added to the
target file

I've manually tested this fix and confirmed it works correctly.

2025-06-02 10:23:52 +00:00

..

add_basic

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

add_multiple

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

add_no_vendored_package_with_alter_registry

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

add_no_vendored_package_with_vendor

Prevent undeclared public network access

2025-04-01 11:41:30 +02:00

add_toolchain

Prevent undeclared public network access

2025-04-01 11:41:30 +02:00

add-basic.in

test: Make edition explicit on packages

2024-02-22 11:37:03 -06:00

build

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

build_prefer_existing_version

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

change_rename_target

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

cyclic_features

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

default_features

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

deprecated_default_features

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

deprecated_section

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

detect_workspace_inherit

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

detect_workspace_inherit_features

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

detect_workspace_inherit_optional

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

detect_workspace_inherit_path_base

Implement path-bases (RFC 3529) 2/n: cargo add support

2024-09-06 10:01:49 -07:00

detect_workspace_inherit_public

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

dev

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

dev_build_conflict

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

dev_existing_path_base

Prevent undeclared public network access

2025-04-01 11:41:30 +02:00

dev_prefer_existing_version

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

dry_run

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

empty_dep_name

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

feature_suggestion_multiple

feat: suggest similarly named features

2025-05-01 16:12:36 +02:00

feature_suggestion_none

feat: add tests for similarly named features

2025-05-01 16:02:15 +02:00

feature_suggestion_single

feat: suggest similarly named features

2025-05-01 16:12:36 +02:00

features

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

features_activated_over_limit

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

features_deactivated_over_limit

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

features_empty

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

features_error_activated_over_limit

feat: suggest similarly named features

2025-05-01 16:12:36 +02:00

features_error_deactivated_over_limit

feat: suggest similarly named features

2025-05-01 16:12:36 +02:00

features_multiple_occurrences

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

features_preserve

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

features_spaced_values

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

features_unknown

feat: suggest similarly named features

2025-05-01 16:12:36 +02:00

features_unknown_no_features

fix: output a blank line between items

2025-04-30 19:56:31 +02:00

git

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

git_branch

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

git_conflicts_namever

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

git_dev

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

git_inferred_name

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

git_inferred_name_multiple

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

git_multiple_names

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

git_multiple_packages_features

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

git_registry

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

git_rev

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

git_tag

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

help

feat: vcs, color, and message format native completion

2025-03-20 22:16:27 +08:00

infer_prerelease

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

invalid_arg

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

invalid_git_name

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

invalid_key_inherit_dependency

Prevent undeclared public network access

2025-04-01 11:41:30 +02:00

invalid_key_overwrite_inherit_dependency

Prevent undeclared public network access

2025-04-01 11:41:30 +02:00

invalid_key_rename_inherit_dependency

Prevent undeclared public network access

2025-04-01 11:41:30 +02:00

invalid_manifest

Update annotate-snippets from 0.11.4 to 0.11.5

2025-02-09 12:46:36 -08:00

invalid_name_external

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

invalid_path

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

invalid_path_name

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

invalid_path_self

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

invalid_target_empty

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

invalid_vers

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

list_features

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

list_features_path

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

list_features_path_no_default

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

locked_changed

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

locked_unchanged

feat: make lockfile v4 the default

2024-09-24 20:43:02 -04:00

lockfile_updated

feat: make lockfile v4 the default

2024-09-24 20:43:02 -04:00

manifest_path_package

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

merge_activated_features

Prevent undeclared public network access

2025-04-01 11:41:30 +02:00

missing_at_in_crate_spec

feat(add): check if given crate argument would be valid with inserted @ symbol, suggest fixed argument

2025-04-27 01:23:51 +02:00

multiple_conflicts_with_features

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

multiple_conflicts_with_rename

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

namever

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

no_args

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

no_default_features

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

no_optional

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

no_public

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

normalize_name_git

test(add): Make name normalization test names consistent

2024-12-05 09:15:17 -06:00

normalize_name_path

test(add): Make name normalization test names consistent

2024-12-05 09:15:17 -06:00

normalize_name_path_existing

Prevent undeclared public network access

2025-04-01 11:41:30 +02:00

normalize_name_registry

test(add): Make name normalization test names consistent

2024-12-05 09:15:17 -06:00

normalize_name_registry_existing

test(add): Make name normalization test names consistent

2024-12-05 09:15:17 -06:00

normalize_name_registry_yanked

fix(add): Don't select yanked versions when normalizing names

2024-12-05 09:48:21 -06:00

normalize_name_workspace_dep

test(add): Make name normalization test names consistent

2024-12-05 09:15:17 -06:00

offline_empty_cache

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

optional

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_default_features

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

overwrite_default_features_with_no_default_features

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

overwrite_features

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_git_with_path

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_inherit_features_noop

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_inherit_noop

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_inherit_optional_noop

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_inline_features

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_name_dev_noop

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_name_noop

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_no_default_features

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

overwrite_no_default_features_with_default_features

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

overwrite_no_optional

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_no_optional_with_optional

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_no_public

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_no_public_with_public

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_optional

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_optional_with_no_optional

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_optional_with_optional

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_path_base_with_version

Implement path-bases (RFC 3529) 2/n: cargo add support

2024-09-06 10:01:49 -07:00

overwrite_path_noop

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_path_with_version

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

overwrite_preserves_inline_table

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_public

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_public_with_no_public

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_rename_with_no_rename

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

overwrite_rename_with_rename

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

overwrite_rename_with_rename_noop

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

overwrite_version_with_git

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_version_with_path

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_with_rename

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

overwrite_workspace_dep

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

overwrite_workspace_dep_features

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

path

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

path_base

Prevent undeclared public network access

2025-04-01 11:41:30 +02:00

path_base_inferred_name

Prevent undeclared public network access

2025-04-01 11:41:30 +02:00

path_base_missing_base_path

Prevent undeclared public network access

2025-04-01 11:41:30 +02:00

path_base_unstable

Prevent undeclared public network access

2025-04-01 11:41:30 +02:00

path_dev

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

path_inferred_name

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

path_inferred_name_conflicts_full_feature

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

prefixed_v_in_version

add: Added error message for when v is prefixed with version

2025-05-03 22:25:12 +05:30

preserve_dep_std_table

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

preserve_features_sorted

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

preserve_features_table

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

preserve_features_unsorted

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

preserve_sorted

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

preserve_unsorted

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

public

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

quiet

refactor: Resolve deprecations

2024-05-27 21:27:03 -05:00

registry

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

rename

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

require_weak

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

rust_version_ignore

feat: Stabilize MSRV-aware resolver config

2024-10-04 12:49:28 -05:00

rust_version_incompatible

feat: Stabilize MSRV-aware resolver config

2024-10-04 12:49:28 -05:00

rust_version_latest

feat: Stabilize MSRV-aware resolver config

2024-10-04 12:49:28 -05:00

rust_version_older

feat: Stabilize MSRV-aware resolver config

2024-10-04 12:49:28 -05:00

rustc_ignore

feat: Stabilize MSRV-aware resolver config

2024-10-04 12:49:28 -05:00

rustc_incompatible

feat: Stabilize MSRV-aware resolver config

2024-10-04 12:49:28 -05:00

rustc_latest

feat: Stabilize MSRV-aware resolver config

2024-10-04 12:49:28 -05:00

rustc_older

feat: Stabilize MSRV-aware resolver config

2024-10-04 12:49:28 -05:00

script_bare

feat(toml): Allow adding/removing from cargo scripts

2024-11-26 12:23:48 -06:00

script_frontmatter

feat(toml): Allow adding/removing from cargo scripts

2024-11-26 12:23:48 -06:00

script_shebang

feat(toml): Allow adding/removing from cargo scripts

2024-11-26 12:23:48 -06:00

sorted_table_with_dotted_item

fix(resolve): Generalize term describing updates

2024-08-30 09:26:56 -05:00

target

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

target_cfg

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

unknown_inherited_feature

fix: output a blank line between items

2025-04-30 19:56:31 +02:00

vers

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

workspace_name

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

workspace_path

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

workspace_path_dev

fix(resolve): Dont show locking workspace members

2024-08-22 16:57:06 -05:00

yanked

test(add): Verify yanked behavior

2024-12-05 09:24:46 -06:00

mod.rs

Fix cargo add overwriting symlinked Cargo.toml files (#15281)

2025-06-02 10:23:52 +00:00

symlink.rs

fix: handle symlinks properly in write_atomic

2025-06-02 10:26:42 +05:30