itsscb/chrono
1
0
Fork 0
mirror of https://github.com/chronotope/chrono.git synced 2025-09-28 13:31:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove oldtime::Duration::seconds_nanos (#441)

Browse Source 
It causes a different _increased_ API when features are _disabled_.

It'll be re-added when #286 is finished
This commit is contained in:
Brandon W Maister 2020-07-01 18:08:15 -04:00 committed by GitHub
parent 8bc94d5281
commit ea2d2da905
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -12,8 +12,6 @@ Versions with only mechanical changes will be omitted from the following list.
### New Methods and impls
* `Duration::seconds_nanos` to construct a duration when you have both seconds
and nanoseconds (#426 @sploiselle).
* `Duration::abs` to ensure that a duration is just a magnitude (#418 @abreis).
### Compatibility improvements

17
src/oldtime.rs
View File

@ -136,19 +136,6 @@ impl Duration {
Duration { secs: secs, nanos: nanos as i32 }
}
/// Makes a new `Duration` with the given number of seconds and nanoseconds.
///
/// `nanos` in excess of `999_999_999` are carried over into seconds.
#[inline]
pub fn seconds_nanos(secs: i64, nanos: i32) -> Duration {
let (secs_from_nanos, nanos) = div_mod_floor_64(nanos.into(), NANOS_PER_SEC as i64);
let d = Duration { secs: secs + secs_from_nanos, nanos: nanos as i32 };
if d < MIN || d > MAX {
panic!("Duration::seconds out of bounds");
}
d
}
/// Returns the total number of whole weeks in the duration.
#[inline]
pub fn num_weeks(&self) -> i64 {
@ -663,10 +650,6 @@ mod tests {
fn test_to_std() {
assert_eq!(Duration::seconds(1).to_std(), Ok(StdDuration::new(1, 0)));
assert_eq!(Duration::seconds(86401).to_std(), Ok(StdDuration::new(86401, 0)));
assert_eq!(
Duration::seconds_nanos(86401, 86401).to_std(),
Ok(StdDuration::new(86401, 86401))
);
assert_eq!(Duration::milliseconds(123).to_std(), Ok(StdDuration::new(0, 123000000)));
assert_eq!(Duration::milliseconds(123765).to_std(), Ok(StdDuration::new(123, 765000000)));
assert_eq!(Duration::nanoseconds(777).to_std(), Ok(StdDuration::new(0, 777)));