From 59af53d53ee99ea133790ad41a85d67cdb1d78b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francisco=20Jos=C3=A9=20G=C3=B3mez?= Date: Fri, 5 Sep 2025 15:20:15 -0400 Subject: [PATCH] fix(embassy-stm32): Remove duplicate fn call, vestigial from earlier refcount implementation Refs: #4577 --- embassy-stm32/CHANGELOG.md | 4 +--- embassy-stm32/src/dac/mod.rs | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/embassy-stm32/CHANGELOG.md b/embassy-stm32/CHANGELOG.md index a473834dd..5635481fa 100644 --- a/embassy-stm32/CHANGELOG.md +++ b/embassy-stm32/CHANGELOG.md @@ -13,9 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - fix: stm32/i2c in master mode (blocking): subsequent transmissions failed after a NACK was received - feat: stm32/timer: add set_polarity functions for main and complementary outputs in complementary_pwm - Add I2S support for STM32F1, STM32C0, STM32F0, STM32F3, STM32F7, STM32G0, STM32WL, STM32H5, STM32H7RS -### Fixed - -- STM32: Prevent dropped DacChannel from disabling Dac peripheral if another DacChannel is still in scope ([#4577](https://github.com/embassy-rs/embassy/pull/4577)) +- fix: STM32: Prevent dropped DacChannel from disabling Dac peripheral if another DacChannel is still in scope ([#4577](https://github.com/embassy-rs/embassy/pull/4577)) - feat: Added support for more OctoSPI configurations (e.g. APS6408 RAM) ([#4581](https://github.com/embassy-rs/embassy/pull/4581)) ## 0.4.0 - 2025-08-26 diff --git a/embassy-stm32/src/dac/mod.rs b/embassy-stm32/src/dac/mod.rs index bc6c3cd34..08e001337 100644 --- a/embassy-stm32/src/dac/mod.rs +++ b/embassy-stm32/src/dac/mod.rs @@ -575,8 +575,6 @@ impl<'d, T: Instance, M: PeriMode> Dac<'d, T, M> { dma_ch2: Option>, #[cfg(any(dac_v3, dac_v4, dac_v5, dac_v6, dac_v7))] mode: Mode, ) -> Self { - // Enable twice to increment the DAC refcount for each channel. - rcc::enable_and_reset::(); rcc::enable_and_reset::(); let mut ch1 = DacCh1 {