From 1ccf6ef6c0ee5fb141631491c1c6629db218bbc1 Mon Sep 17 00:00:00 2001 From: korbin Date: Sat, 26 Jul 2025 17:41:18 -0600 Subject: [PATCH 1/2] add embassy-net defmt derives for config structs --- embassy-net/src/lib.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/embassy-net/src/lib.rs b/embassy-net/src/lib.rs index 693a39ed5..2b1888170 100644 --- a/embassy-net/src/lib.rs +++ b/embassy-net/src/lib.rs @@ -106,6 +106,7 @@ impl StackResources { /// Static IP address configuration. #[cfg(feature = "proto-ipv4")] #[derive(Debug, Clone, PartialEq, Eq)] +#[cfg_attr(feature = "defmt", derive(defmt::Format))] pub struct StaticConfigV4 { /// IP address and subnet mask. pub address: Ipv4Cidr, @@ -118,6 +119,7 @@ pub struct StaticConfigV4 { /// Static IPv6 address configuration #[cfg(feature = "proto-ipv6")] #[derive(Debug, Clone, PartialEq, Eq)] +#[cfg_attr(feature = "defmt", derive(defmt::Format))] pub struct StaticConfigV6 { /// IP address and subnet mask. pub address: Ipv6Cidr, @@ -130,6 +132,7 @@ pub struct StaticConfigV6 { /// DHCP configuration. #[cfg(feature = "dhcpv4")] #[derive(Debug, Clone, PartialEq, Eq)] +#[cfg_attr(feature = "defmt", derive(defmt::Format))] #[non_exhaustive] pub struct DhcpConfig { /// Maximum lease duration. @@ -169,6 +172,7 @@ impl Default for DhcpConfig { /// Network stack configuration. #[derive(Debug, Clone, Default)] +#[cfg_attr(feature = "defmt", derive(defmt::Format))] #[non_exhaustive] pub struct Config { /// IPv4 configuration @@ -220,6 +224,7 @@ impl Config { /// Network stack IPv4 configuration. #[cfg(feature = "proto-ipv4")] #[derive(Debug, Clone, Default)] +#[cfg_attr(feature = "defmt", derive(defmt::Format))] pub enum ConfigV4 { /// Do not configure IPv4. #[default] @@ -234,6 +239,7 @@ pub enum ConfigV4 { /// Network stack IPv6 configuration. #[cfg(feature = "proto-ipv6")] #[derive(Debug, Clone, Default)] +#[cfg_attr(feature = "defmt", derive(defmt::Format))] pub enum ConfigV6 { /// Do not configure IPv6. #[default] From 1379e15d6385e6a4613dc4ddd543ad9f42805bd2 Mon Sep 17 00:00:00 2001 From: korbin Date: Sat, 26 Jul 2025 17:45:27 -0600 Subject: [PATCH 2/2] add embassy-time/defmt config flag passthrough --- embassy-net/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/embassy-net/Cargo.toml b/embassy-net/Cargo.toml index 526c8a4b3..a2665c770 100644 --- a/embassy-net/Cargo.toml +++ b/embassy-net/Cargo.toml @@ -24,7 +24,7 @@ features = ["defmt", "tcp", "udp", "raw", "dns", "icmp", "dhcpv4", "proto-ipv6", [features] ## Enable defmt -defmt = ["dep:defmt", "smoltcp/defmt", "embassy-net-driver/defmt", "heapless/defmt-03", "defmt?/ip_in_core"] +defmt = ["dep:defmt", "smoltcp/defmt", "embassy-net-driver/defmt", "embassy-time/defmt", "heapless/defmt-03", "defmt?/ip_in_core"] ## Trace all raw received and transmitted packets using defmt or log. packet-trace = []