itsscb/embassy
1
0
Fork 0
mirror of https://github.com/embassy-rs/embassy.git synced 2025-09-26 20:00:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle OSPI address errors

Browse Source 
We were using OSPI in indirect mode via DMA and noticed that the transfer future would never resolve. It was forever busy-looping in `finish_dma()` on the `while !regs.sr().read().tcf() {}` line.

After some debugging we noticed that the the `TEF` flag is set. The data sheet says the following about this flag:

> The following errors set the TEF flag in OCTOSPI_SR and generates an interrupt if enabled (TEIE = 1 in OCTOSPI_CR):
> - in indirect or automatic status-polling mode, when a wrong address has been programmed in OCTOSPI_AR (according to the device size defined by DEVSIZE[4:0]).
> - in indirect mode, if the address plus the data length exceed the device size: TEF is set as soon as the access is triggered.

Indeed we were configuring our device size to 0 while specifying a non-zero address.

Detect this condition and return an error early - as soon as we configure the registers (which, according to the data sheet, should be enough to raise the flag)

Also document this behavior on the respective TransferConfig and Config fields.

Testing
-------
See https://github.com/goodhoko/spi-error-test/blob/main/src/main.rs
This commit is contained in:
goodhoko 2025-09-15 15:34:07 +02:00
parent fe95e33861
commit 8ed1e796ba
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
embassy-stm32/src/ospi/mod.rs
View File

@ -31,7 +31,9 @@ pub struct Config {
/// Indicates the type of external device connected
pub memory_type: MemoryType, // Need to add an additional enum to provide this public interface
/// Defines the size of the external device connected to the OSPI corresponding
/// to the number of address bits required to access the device
/// to the number of address bits required to access the device.
/// When using indirect mode, [`TransferConfig::address`] + the length of the data being read
/// or written must fit within the configured `device_size`, otherwise an error is returned.
pub device_size: MemorySize,
/// Sets the minimum number of clock cycles that the chip select signal must be held high
/// between commands
@ -95,10 +97,11 @@ pub struct TransferConfig {
pub isize: AddressSize,
/// Instruction Double Transfer rate enable
pub idtr: bool,
/// Address width (ADMODE)
pub adwidth: OspiWidth,
/// Device memory address
/// Device memory address.
/// In indirect mode, this value + the length of the data being read or written must be within
/// configured [`Config::device_size`], otherwise the transfer returns an error.
pub address: Option<u32>,
/// Number of Address Bytes
pub adsize: AddressSize,
@ -528,6 +531,18 @@ impl<'d, T: Instance, M: PeriMode> Ospi<'d, T, M> {
}
}
// The following errors set the TEF flag in OCTOSPI_SR register:
// - in indirect or automatic status-polling mode, when a wrong address has been programmed
// in OCTOSPI_AR (according to the device size defined by DEVSIZE[4:0])
// - in indirect mode, if the address plus the data length exceed the device size: TEF is
// set as soon as the access is triggered.
if T::REGS.sr().read().tef() {
// Clear the TEF register to make it ready for the next transfer.
T::REGS.fcr().write(|w| w.set_ctef(true));
return Err(OspiError::InvalidCommand);
}
Ok(())
}