From 1347daf7635007423c6df1464c4f45580d3236d0 Mon Sep 17 00:00:00 2001 From: Matt Johnston Date: Fri, 15 Aug 2025 11:11:09 +0800 Subject: [PATCH 1/2] stm32: Fix vrefbuf trace with log feature Vrs and Hiz don't implement core::fmt::Display --- embassy-stm32/CHANGELOG.md | 2 ++ embassy-stm32/src/vrefbuf/mod.rs | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/embassy-stm32/CHANGELOG.md b/embassy-stm32/CHANGELOG.md index c68377432..0c2d23246 100644 --- a/embassy-stm32/CHANGELOG.md +++ b/embassy-stm32/CHANGELOG.md @@ -8,6 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased - ReleaseDate +- fix: Fix vrefbuf building with log feature + ## 0.3.0 - 2025-08-12 - feat: Added VREFBUF voltage reference buffer driver ([#4524](https://github.com/embassy-rs/embassy/pull/4524)) diff --git a/embassy-stm32/src/vrefbuf/mod.rs b/embassy-stm32/src/vrefbuf/mod.rs index 54b4f8903..ccbd748d5 100644 --- a/embassy-stm32/src/vrefbuf/mod.rs +++ b/embassy-stm32/src/vrefbuf/mod.rs @@ -62,8 +62,8 @@ impl<'d, T: Instance> VoltageReferenceBuffer<'d, T> { } trace!( "Vrefbuf configured with voltage scale {} and impedance mode {}", - voltage_scale, - impedance_mode + voltage_scale as u8, + impedance_mode as u8, ); VoltageReferenceBuffer { vrefbuf: PhantomData } } From 17f50c886105e3aecec8e1e272a34c30fb40a9b6 Mon Sep 17 00:00:00 2001 From: Matt Johnston Date: Fri, 15 Aug 2025 11:12:14 +0800 Subject: [PATCH 2/2] ci: Build stm32h7s3a8 with log feature Covers some different peripherals to the existing stm32f429zi,log build. --- ci.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci.sh b/ci.sh index 94bf83675..4fdce65d2 100755 --- a/ci.sh +++ b/ci.sh @@ -148,7 +148,7 @@ cargo batch \ --- build --release --manifest-path embassy-stm32/Cargo.toml --target thumbv7em-none-eabi --features stm32h7b3ai,defmt,exti,time-driver-tim1,time \ --- build --release --manifest-path embassy-stm32/Cargo.toml --target thumbv7em-none-eabi --features stm32h7r3z8,defmt,exti,time-driver-tim1,time \ --- build --release --manifest-path embassy-stm32/Cargo.toml --target thumbv7em-none-eabi --features stm32h7r7a8,defmt,exti,time-driver-tim1,time \ - --- build --release --manifest-path embassy-stm32/Cargo.toml --target thumbv7em-none-eabi --features stm32h7s3a8,defmt,exti,time-driver-tim1,time \ + --- build --release --manifest-path embassy-stm32/Cargo.toml --target thumbv7em-none-eabi --features stm32h7s3a8,log,exti,time-driver-tim1,time \ --- build --release --manifest-path embassy-stm32/Cargo.toml --target thumbv7em-none-eabi --features stm32h7s7z8,defmt,exti,time-driver-tim1,time \ --- build --release --manifest-path embassy-stm32/Cargo.toml --target thumbv7em-none-eabi --features stm32l431cb,defmt,exti,time-driver-any,time \ --- build --release --manifest-path embassy-stm32/Cargo.toml --target thumbv7em-none-eabi --features stm32l476vg,defmt,exti,time-driver-any,time \