itsscb/esp-hal
1
0
Fork 0
mirror of https://github.com/esp-rs/esp-hal.git synced 2025-09-26 20:00:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

ensure the plan phase accounts for perma-unstable packages (#3799)

Browse Source
This commit is contained in:
Scott Mabin 2025-07-15 15:46:09 +01:00 committed by GitHub
parent 634120f700
commit 1d99fae9ee
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
xtask/src/commands/release/bump_version.rs
View File

@ -11,7 +11,7 @@ use serde::{Deserialize, Serialize};
use strum::IntoEnumIterator;
use toml_edit::{Item, TableLike, Value};
use crate::{cargo::CargoToml, changelog::Changelog, commands::PLACEHOLDER, Package, Version};
use crate::{Package, Version, cargo::CargoToml, changelog::Changelog, commands::PLACEHOLDER};
#[derive(Debug, Clone, Deserialize, Serialize, PartialEq, Eq)]
pub enum VersionBump {
@ -65,18 +65,6 @@ pub fn update_package(
version: &VersionBump,
dry_run: bool,
) -> Result<semver::Version> {
let version = {
if package.package() == Package::EspRomSys && version != &VersionBump::Patch {
log::warn!(
"Bump '{:?}' is not acceptable for package esp-rom-sys - using 'Patch'",
version
);
&VersionBump::Patch
} else {
version
}
};
check_crate_before_bumping(package)?;
let new_version = bump_crate_version(package, version, dry_run)?;
finalize_changelog(package, &new_version, dry_run)?;

14
xtask/src/commands/release/plan.rs
View File

@ -120,6 +120,20 @@ pub fn plan(workspace: &Path, args: PlanArgs) -> Result<()> {
} else {
ReleaseType::Minor
};
// Special case: some packages are perma-unstable, meaning they won't ever have a stable
// release. For these packages, we always use a patch release.
let amount = match package {
Package::EspRomSys if amount != ReleaseType::Patch => {
log::debug!(
"Bump '{:?}' is not acceptable for package esp-rom-sys - using 'Patch'",
amount
);
ReleaseType::Patch
}
_ => amount,
};
log::debug!("{} needs {:?} version bump", package, amount);
Some(amount)
} else {