upgrade to 1.89.0.0 for CI (#4102)

* upgrade to 1.89.0.0 for CI

* regenerate baseline

* Resolve clippy errors

---------

Co-authored-by: Jesse Braham <jesse@beta7.io>

.github/workflows/ci.yml

@@ -71,7 +71,7 @@ jobs:
       # Install the Rust toolchain for Xtensa devices:
       - uses: esp-rs/xtensa-toolchain@v1.6
         with:
-          version: 1.88.0.0
+          version: 1.89.0.0
 
       # Install the Rust stable toolchain for RISC-V devices:
       - uses: dtolnay/rust-toolchain@v1

.github/workflows/documentation.yml

@@ -86,7 +86,7 @@ jobs:
       - uses: esp-rs/xtensa-toolchain@v1.6
         with:
           default: true
-          version: 1.88.0.0
+          version: 1.89.0.0
 
       # xtensa-toolchain installs rustup and a basic toolchain, but doesn't install rust-src
       - name: rust-src

.github/workflows/hil.yml

@@ -124,7 +124,7 @@ jobs:
         with:
           buildtargets: ${{ matrix.target.soc }}
           default: true
-          version: 1.88.0.0
+          version: 1.89.0.0
 
       - name: Build tests
         run: cargo xtask build tests ${{ matrix.target.soc }}

esp-hal/src/lcd_cam/cam.rs

@@ -189,10 +189,10 @@ impl<'d> Camera<'d> {
         )
         .map_err(ConfigError::Clock)?;
 
-        if let Some(value) = config.line_interrupt {
+        if let Some(value) = config.line_interrupt
-            if value > 0b0111_1111 {
+            && value > 0b0111_1111
-                return Err(ConfigError::LineInterrupt);
+        {
-            }
+            return Err(ConfigError::LineInterrupt);
         }
 
         self.regs().cam_ctrl().write(|w| {

esp-hal/src/touch.rs

@@ -151,10 +151,10 @@ impl<Tm: TouchMode, Dm: DriverMode> Touch<'_, Tm, Dm> {
 
         // Default nr of sleep cycles from IDF
         let mut sleep_cyc = 0x1000;
-        if let Some(config) = config {
+        if let Some(config) = config
-            if let Some(slp) = config.sleep_cycles {
+            && let Some(slp) = config.sleep_cycles
-                sleep_cyc = slp;
+        {
-            }
+            sleep_cyc = slp;
         }
 
         Self::initialize_common(config);
@@ -201,10 +201,10 @@ impl<'d> Touch<'d, OneShot, Blocking> {
 
         // Default nr of sleep cycles from IDF
         let mut sleep_cyc = 0x1000;
-        if let Some(config) = config {
+        if let Some(config) = config
-            if let Some(slp) = config.sleep_cycles {
+            && let Some(slp) = config.sleep_cycles
-                sleep_cyc = slp;
+        {
-            }
+            sleep_cyc = slp;
         }
 
         Self::initialize_common(config);

xtask/Cargo.toml

@@ -35,7 +35,7 @@ reqwest = { version = "0.12.12", features = [
 ], optional = true }
 
 # This pulls a gazillion crates - don't include it by default
-cargo-semver-checks = { version = "0.41.0", optional = true }
+cargo-semver-checks = { version = "0.43.0", optional = true }
 
 flate2 = { version = "1.1.1", optional = true }
 temp-file = { version = "0.1.9", optional = true }