itsscb/esp-hal
1
0
Fork 0
mirror of https://github.com/esp-rs/esp-hal.git synced 2025-09-28 04:40:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace length check with debug assert (#3599)

Browse Source
This commit is contained in:
Dániel Buga 2025-06-05 14:07:24 +02:00 committed by GitHub
parent 5b55161885
commit 8237e04fff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
esp-hal/src/i2c/master/mod.rs
View File

@ -2125,11 +2125,6 @@ impl Driver<'_> {
/// Reads from RX FIFO into the given buffer.
fn read_all_from_fifo(&self, buffer: &mut [u8]) -> Result<(), Error> {
// we don't support single I2C reads larger than the FIFO
if buffer.len() > I2C_FIFO_SIZE {
return Err(Error::FifoExceeded);
}
if self.regs().sr().read().rxfifo_cnt().bits() < buffer.len() as u8 {
return Err(Error::ExecutionIncomplete);
}
@ -2139,6 +2134,10 @@ impl Driver<'_> {
*byte = read_fifo(self.regs());
}
// The RX FIFO should be empty now. If it is not, it means we queued up reading
// more data than we read, which is an error.
debug_assert!(self.regs().sr().read().rxfifo_cnt().bits() == 0);
Ok(())
}
@ -2382,6 +2381,11 @@ impl Driver<'_> {
stop: bool,
deadline: Deadline,
) -> Result<Option<Instant>, Error> {
// We don't support single I2C reads larger than the FIFO. This should be
// enforced by `VariableChunkIterMut` used in `Driver::read` and
// `Driver::read_async`.
debug_assert!(buffer.len() <= I2C_FIFO_SIZE);
let cmd_iterator = &mut self.regs().comd_iter();
self.setup_read(address, buffer, start, will_continue, cmd_iterator)?;