diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index f9a460b..626bdd7 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -106,6 +106,6 @@ jobs: - uses: actions-rs/cargo@v1 with: command: clippy - # `identity_op` and `or_fun_call` leads to false positives - # `too-many-arguments` is relatively arbitrary - args: -- -D warnings -A clippy::identity_op -A clippy::or_fun_call -A clippy::too-many-arguments + # `identity_op` and `or_fun_call` may lead to false positives + # `too_many_arguments` is relatively arbitrary + args: -- -D warnings -A clippy::identity_op -A clippy::or_fun_call -A clippy::too_many_arguments diff --git a/espflash/src/cli/mod.rs b/espflash/src/cli/mod.rs index 74f016b..20d394d 100644 --- a/espflash/src/cli/mod.rs +++ b/espflash/src/cli/mod.rs @@ -122,7 +122,6 @@ pub fn board_info(opts: ConnectOpts, config: Config) -> Result<()> { Ok(()) } -#[allow(clippy::too_many_arguments)] pub fn save_elf_as_image( chip: Chip, elf_data: &[u8], @@ -220,7 +219,6 @@ pub fn save_elf_as_image( Ok(()) } -#[allow(clippy::too_many_arguments)] pub fn flash_elf_image( flasher: &mut Flasher, elf_data: &[u8], diff --git a/espflash/src/flasher.rs b/espflash/src/flasher.rs index b158b23..7e4f746 100644 --- a/espflash/src/flasher.rs +++ b/espflash/src/flasher.rs @@ -443,7 +443,6 @@ impl Flasher { } /// Load an elf image to flash and execute it - #[allow(clippy::too_many_arguments)] pub fn load_elf_to_flash_with_format( &mut self, elf_data: &[u8],