Code cleaunp

This commit is contained in:
Sergio Gasquez 2022-08-30 12:33:34 +00:00
parent 9c041f8e9e
commit d6031ee139
2 changed files with 0 additions and 32 deletions

View File

@ -14,7 +14,6 @@ type Result<T> = std::result::Result<T, Box<dyn std::error::Error + Send + Sync>
// - Add minified-esp-idf installation support
// - Add clear_cache funtionality
// - Rustup_home and cargo_home are not used
// - Prettify prints (add emojis)
// - Avoid using shell commands
// - Maybe split toolchain into toolchain(espidf, gcc, llvm...) and rust(rust checks, instalaltion and crates)
// - Add subcommand test that downloads a projects and builds it
@ -288,27 +287,9 @@ fn install(args: InstallOpts) -> Result<()> {
}
// TODO: Install extra crates
// match args.extra_crates {
// // args.extra_crates.contains("cargo") => {
// // println!("Installing cargo");
// // install_cargo();
// // }
// // "mingw" => {
// // // match arch {
// // // "x86_64-pc-windows-gnu" => {
// // // install_mingw(toolchain);
// // // }
// // // _ => { println!("Ok"); }
// // // }
// // },
// _ => {
// println!("No extra tools selected");
// }
// }
// TODO: Clear cache
// TODO: Set environment
println!("{} Updating environment variables:", DIAMOND);
for e in exports.iter() {
println!("{}", e);

View File

@ -287,19 +287,6 @@ pub fn install_espidf(targets: &str, version: &str) -> Result<(), String> {
println!("{} ESP-IDF installation failed", ERROR);
}
}
// match std::process::Command::new(install_script_path)
// .arg("esp32 esp32s2")
// .stdout(Stdio::piped())
// .output()
// {
// Ok(child_output) => {
// let result = String::from_utf8_lossy(&child_output.stdout);
// println!("ESP-IDF installation succeeded: {}", result);
// }
// Err(e) => {
// println!("ESP-IDF installation failed: {}", e);
// }
// }
println!("{} Installing CMake", WRENCH);
let mut arguments: Vec<String> = [].to_vec();