From 57a0ec6e13f3ce7602ba5c6752e15ac607a11f08 Mon Sep 17 00:00:00 2001 From: Brandon Conway Date: Mon, 15 Mar 2021 09:14:30 -0700 Subject: [PATCH 1/3] add_file should take an optional buf name/id --- lua/harpoon/mark.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lua/harpoon/mark.lua b/lua/harpoon/mark.lua index 8ce8a47..1919eac 100644 --- a/lua/harpoon/mark.lua +++ b/lua/harpoon/mark.lua @@ -74,8 +74,8 @@ local function swap(a_idx, b_idx) config.marks[b_idx] = tmp end -M.add_file = function() - local buf_name = get_buf_name() +M.add_file = function(file_name_or_buf_id) + local buf_name = get_buf_name(file_name_or_buf_id) if valid_index(get_index_of(buf_name)) then -- we don't alter file layout. From ee9e803ae61daace1f9b7906a7c0a9e37b678378 Mon Sep 17 00:00:00 2001 From: Brandon Conway Date: Mon, 15 Mar 2021 09:14:43 -0700 Subject: [PATCH 2/3] Don't mark nil or "" buffer names --- lua/harpoon/mark.lua | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lua/harpoon/mark.lua b/lua/harpoon/mark.lua index 1919eac..2fdfe66 100644 --- a/lua/harpoon/mark.lua +++ b/lua/harpoon/mark.lua @@ -82,6 +82,11 @@ M.add_file = function(file_name_or_buf_id) return end + if buf_name == "" or buf_name == nil then + print("Couldn't find a valid file name to mark, sorry.") + return + end + local config = harpoon.get_mark_config() for idx = 1, #config.marks do if config.marks[idx] == nil then From d8213986e80abcb31672689c9fd8bab45f168c9e Mon Sep 17 00:00:00 2001 From: Brandon Conway Date: Mon, 15 Mar 2021 11:56:05 -0700 Subject: [PATCH 3/3] Use error instead of print --- lua/harpoon/mark.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lua/harpoon/mark.lua b/lua/harpoon/mark.lua index 2fdfe66..3b6543c 100644 --- a/lua/harpoon/mark.lua +++ b/lua/harpoon/mark.lua @@ -83,7 +83,7 @@ M.add_file = function(file_name_or_buf_id) end if buf_name == "" or buf_name == nil then - print("Couldn't find a valid file name to mark, sorry.") + error("Couldn't find a valid file name to mark, sorry.") return end