diff --git a/src/lib.rs b/src/lib.rs index b2b88ff6..221e169c 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -73,8 +73,7 @@ #![deny(missing_docs)] #![deny(rust_2018_compatibility)] #![deny(rust_2018_idioms)] -// #![deny(warnings)] -#![allow(warnings)] // FIXME +#![deny(warnings)] pub use binary_heap::BinaryHeap; pub use generic_array::typenum::consts; diff --git a/src/pool/cas.rs b/src/pool/cas.rs index ffbedeaf..20295026 100644 --- a/src/pool/cas.rs +++ b/src/pool/cas.rs @@ -7,7 +7,7 @@ use core::{ cell::UnsafeCell, convert::TryFrom, marker::PhantomData, - mem::{self, MaybeUninit}, + mem, num::NonZeroUsize, ptr::NonNull, sync::atomic::{AtomicUsize, Ordering}, diff --git a/src/pool/llsc.rs b/src/pool/llsc.rs index 3d1c61f4..1aec5276 100644 --- a/src/pool/llsc.rs +++ b/src/pool/llsc.rs @@ -4,9 +4,11 @@ pub use core::ptr::NonNull as Ptr; use core::{ cell::UnsafeCell, ptr, - sync::atomic::{self, AtomicPtr, Ordering}, + sync::atomic::{AtomicPtr, Ordering}, }; +/// Unfortunate implementation detail required to use the +/// [`Pool.grow_exact`](struct.Pool.html#method.grow_exact) method pub struct Node { next: AtomicPtr>, pub(crate) data: UnsafeCell, diff --git a/src/pool/mod.rs b/src/pool/mod.rs index d4165bd3..cbc3eb0f 100644 --- a/src/pool/mod.rs +++ b/src/pool/mod.rs @@ -224,16 +224,14 @@ //! //! 4. "Hazard pointers: Safe memory reclamation for lock-free objects." Michael, Maged M. -use core::{any::TypeId, mem, sync::atomic::Ordering}; +use core::{any::TypeId, mem}; use core::{ - cell::UnsafeCell, cmp, fmt, hash::{Hash, Hasher}, marker::PhantomData, mem::MaybeUninit, ops::{Deref, DerefMut}, ptr, - sync::atomic::AtomicPtr, }; use as_slice::{AsMutSlice, AsSlice}; @@ -394,7 +392,7 @@ impl Pool { } #[cfg(not(target_arch = "x86_64"))] - () => self.stack.push(NonNull::from(p)), + () => self.stack.push(core::ptr::NonNull::from(p)), } } cap