From a6e76090e84a4c4d32b62a4dc1e4f91b5f62968c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Breno=20Uch=C3=B4a=20-=20DSuite?= <47765861+breno-dsuite@users.noreply.github.com> Date: Fri, 15 May 2020 16:43:43 -0300 Subject: [PATCH 1/5] Fix kt-params Link --- www/docs.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/docs.md b/www/docs.md index ebd3a60f..17c20345 100644 --- a/www/docs.md +++ b/www/docs.md @@ -348,7 +348,7 @@ will be included. If you wish to include the values of other elements, you can use the [kt-include](/attributes/kt-include) attribute with a CSS selector of all the elements whose values you want to include in the request. -If you wish to filter out some parameters you can use the [kt-parameters](/attributes/kt-parameters) attribute. +If you wish to filter out some parameters you can use the [kt-params](/attributes/kt-params) attribute. Finally, if you want to programatically modify the parameters, you can use the [configRequest.kutty](/events#configRequest.kutty) event. @@ -541,4 +541,4 @@ You can set them directly in javascript, or you can use a `meta` tag: And that's it! Have fun with kutty: you can accomplish [quite a bit](/examples) without a lot of code. - \ No newline at end of file + From 7237b93fb246645766b646af6d76479327063ec1 Mon Sep 17 00:00:00 2001 From: Timothy Levi Campbell Date: Fri, 15 May 2020 16:20:05 -0400 Subject: [PATCH 2/5] Update inline validation example description --- www/examples.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/examples.md b/www/examples.md index c35df5a3..580b1812 100644 --- a/www/examples.md +++ b/www/examples.md @@ -15,7 +15,7 @@ You can copy and paste them and then adjust them for your needs. | [Bulk Update](/examples/bulk-update) | Demonstrates bulk updating of multiple rows of data | [Click To Load](/examples/click-to-load) | Demonstrates clicking to load more rows in a table | [Lazy Loading](/examples/lazy-load) | Demonstrates how to lazy load content -| [Inline Validation](/examples/inline-validation) | Demonstrates how to lazy load content +| [Inline Validation](/examples/inline-validation) | Demonstrates how to do inline field validation | [Infinite Scroll](/examples/infinite-scroll) | Demonstrates infinite scrolling of a page | [Active Search](/examples/active-search) | Demonstrates the active search box pattern | [Progress Bar](/examples/progress-bar) | Demonstrates a job-runner like progress bar From cf15267247170a0bda509d860665d8c043cc6fb2 Mon Sep 17 00:00:00 2001 From: Alejandro Schmeichler <31069418+jreviews@users.noreply.github.com> Date: Fri, 15 May 2020 18:36:37 -0400 Subject: [PATCH 3/5] Using ic-post-to instead of kt-post in example --- www/examples/inline-validation.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/examples/inline-validation.md b/www/examples/inline-validation.md index bbb96f6c..492edfa6 100644 --- a/www/examples/inline-validation.md +++ b/www/examples/inline-validation.md @@ -11,7 +11,8 @@ and updates the DOM with the validation results. We start with this form: ```html -

Signup Form

+

Signup Form

+
From 4c00f8f6d6bfe1ac5495a8c697e3c6ee3878726c Mon Sep 17 00:00:00 2001 From: chg20 <469183+chg20@users.noreply.github.com> Date: Sat, 16 May 2020 06:04:55 -0700 Subject: [PATCH 4/5] Update TODO.md --- TODO.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/TODO.md b/TODO.md index 984a138e..f337f98c 100644 --- a/TODO.md +++ b/TODO.md @@ -4,10 +4,6 @@ * Support IE11 (stretch: IE10) * < 6k in .min.gz form -## Launch TODOS - -* Move to development branch - ## Post-Launch TODOS * Clean up event naming From 1cd6ba375053e4def438cb4d9293b4edec57e3d9 Mon Sep 17 00:00:00 2001 From: Robert Schroll Date: Sat, 16 May 2020 12:13:32 -0700 Subject: [PATCH 5/5] Avoid shadowing the global prompt function The prompt variable inside issueAjaxRequest shadowed the prompt function that it was attempting to use, thereby breaking the use of kt-prompt. --- src/kutty.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/kutty.js b/src/kutty.js index 35ce3150..c06cabad 100644 --- a/src/kutty.js +++ b/src/kutty.js @@ -1101,8 +1101,8 @@ var kutty = kutty || (function () { } var promptQuestion = getClosestAttributeValue(elt, "kt-prompt"); if (promptQuestion) { - var prompt = prompt(promptQuestion); - if(!triggerEvent(elt, 'prompt.kutty', {prompt: prompt, target:target})) return endRequestLock(); + var promptResponse = prompt(promptQuestion); + if(!triggerEvent(elt, 'prompt.kutty', {prompt: promptResponse, target:target})) return endRequestLock(); } var confirmQuestion = getClosestAttributeValue(elt, "kt-confirm"); @@ -1112,7 +1112,7 @@ var kutty = kutty || (function () { var xhr = new XMLHttpRequest(); - var headers = getHeaders(elt, target, prompt, eventTarget); + var headers = getHeaders(elt, target, promptResponse, eventTarget); var rawParameters = getInputValues(elt, verb); var filteredParameters = filterValues(rawParameters, elt, verb);