itsscb/htmx
1
0
Fork 0
mirror of https://github.com/bigskysoftware/htmx.git synced 2025-10-04 16:25:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #350 from andyhorng/hx-preserve-fix

Browse Source 
Handle preserved element that might not be existing
This commit is contained in:
1cg 2021-02-05 11:11:51 -07:00 committed by GitHub
commit 8c3ced2573
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/htmx.js
View File

@ -497,7 +497,9 @@ return (function () {
forEach(findAll(fragment, '[hx-preserve], [data-hx-preserve]'), function (preservedElt) { forEach(findAll(fragment, '[hx-preserve], [data-hx-preserve]'), function (preservedElt) {
var id = getAttributeValue(preservedElt, "id"); var id = getAttributeValue(preservedElt, "id");
var oldElt = getDocument().getElementById(id); var oldElt = getDocument().getElementById(id);
if (oldElt != null) {
preservedElt.parentNode.replaceChild(oldElt, preservedElt); preservedElt.parentNode.replaceChild(oldElt, preservedElt);
}
}); });
} }

9
test/attributes/hx-preserve.js
View File

@ -17,5 +17,14 @@ describe("hx-preserve attribute", function () {
byId("d2").innerHTML.should.equal("New Content"); byId("d2").innerHTML.should.equal("New Content");
}) })
it('handles preserved element that might not be existing', function () {
this.server.respondWith("GET", "/test", "<div id='d1' hx-preserve>New Content</div><div id='d2'>New Content</div>");
var div = make("<div hx-get='/test'><div id='d2'>Old Content</div></div>");
div.click();
this.server.respond();
byId("d1").innerHTML.should.equal("New Content");
byId("d2").innerHTML.should.equal("New Content");
})
}); });