itsscb/htmx
1
0
Fork 0
mirror of https://github.com/bigskysoftware/htmx.git synced 2025-10-04 00:05:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add support for 304 response code in addition to the 204 response code

Browse Source
This commit is contained in:
carson 2020-09-07 10:06:35 -06:00
parent 278b5f1196
commit d5f6ef2900
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/htmx.js
View File

@ -1579,8 +1579,8 @@ return (function () {
if (this.status === 286) { if (this.status === 286) {
cancelPolling(elt); cancelPolling(elt);
} }
// don't process 'No Content' response // don't process 'No Content' or 'Not Modified' response
if (this.status !== 204) { if (this.status !== 204 && this.status !== 304) {
if (!triggerEvent(target, 'htmx:beforeSwap', eventDetail)) return; if (!triggerEvent(target, 'htmx:beforeSwap', eventDetail)) return;
var resp = this.response; var resp = this.response;

11
test/core/ajax.js
View File

@ -240,6 +240,17 @@ describe("Core htmx AJAX Tests", function(){
btn.innerHTML.should.equal("Click Me!"); btn.innerHTML.should.equal("Click Me!");
}); });
it('handles 304 NOT MODIFIED responses properly', function()
{
this.server.respondWith("GET", "/test", [204, {}, "No Content!"]);
var btn = make('<button hx-get="/test">Click Me!</button>');
btn.click();
btn.innerHTML.should.equal("Click Me!");
this.server.respond();
btn.innerHTML.should.equal("Click Me!");
});
it('handles hx-trigger with non-default value', function() it('handles hx-trigger with non-default value', function()
{ {
this.server.respondWith("GET", "/test", "Clicked!"); this.server.respondWith("GET", "/test", "Clicked!");