itsscb/htmx
1
0
Fork 0
mirror of https://github.com/bigskysoftware/htmx.git synced 2025-10-02 15:25:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not boost forms with method="dialog" (#2752)

Browse Source 
* Do not boost forms with method="dialog"

* Clean up
This commit is contained in:
pokonski 2024-08-05 21:38:51 +02:00 committed by GitHub
parent 941e94fb98
commit ee9b0e0390
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/htmx.js
View File

@ -2277,7 +2277,7 @@ var htmx = (function() {
* @param {HtmxTriggerSpecification[]} triggerSpecs * @param {HtmxTriggerSpecification[]} triggerSpecs
*/ */
function boostElement(elt, nodeData, triggerSpecs) { function boostElement(elt, nodeData, triggerSpecs) {
if ((elt instanceof HTMLAnchorElement && isLocalLink(elt) && (elt.target === '' || elt.target === '_self')) || elt.tagName === 'FORM') { if ((elt instanceof HTMLAnchorElement && isLocalLink(elt) && (elt.target === '' || elt.target === '_self')) || (elt.tagName === 'FORM' && String(getRawAttribute(elt, 'method')).toLowerCase() !== 'dialog')) {
nodeData.boosted = true nodeData.boosted = true
let verb, path let verb, path
if (elt.tagName === 'A') { if (elt.tagName === 'A') {

8
test/attributes/hx-boost.js
View File

@ -71,6 +71,14 @@ describe('hx-boost attribute', function() {
div.innerHTML.should.equal('Boosted') div.innerHTML.should.equal('Boosted')
}) })
it('does not boost forms with method="dialog"', function() {
make('<div hx-boost="true"><form id="f1" action="/test" method="dialog"><button id="b1">close</button></form></div>')
var form = byId('f1')
var internalData = htmx._('getInternalData')(form)
should.equal(undefined, internalData.boosted)
})
it('handles basic anchor properly w/ data-* prefix', function() { it('handles basic anchor properly w/ data-* prefix', function() {
this.server.respondWith('GET', '/test', 'Boosted') this.server.respondWith('GET', '/test', 'Boosted')
var div = make('<div data-hx-target="this" data-hx-boost="true"><a id="a1" href="/test">Foo</a></div>') var div = make('<div data-hx-target="this" data-hx-boost="true"><a id="a1" href="/test">Foo</a></div>')