Merge #9288

9288: internal: cleanup tests r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

crates/ide_assists/src/handlers/replace_impl_trait_with_generic.rs

@@ -105,12 +105,13 @@ fn foo<B: Bar
     }
 
     #[test]
-    #[ignore = "This case is very rare but there is no simple solutions to fix it."]
     fn replace_impl_trait_with_exist_generic_letter() {
+        // FIXME: This is wrong, we should pick a different name if the one we
+        // want is already bound.
         check_assist(
             replace_impl_trait_with_generic,
             r#"fn foo<B>(bar: $0impl Bar) {}"#,
-            r#"fn foo<B, C: Bar>(bar: C) {}"#,
+            r#"fn foo<B, B: Bar>(bar: B) {}"#,
         );
     }
 

crates/ide_db/src/helpers/insert_use/tests.rs

@@ -511,13 +511,14 @@ use std::io;
 }
 
 #[test]
-#[ignore] // FIXME: Support this
 fn split_out_merge() {
+    // FIXME: This is suboptimal, we want to get `use std::fmt::{self, Result}`
+    // instead.
     check_module(
         "std::fmt::Result",
         r"use std::{fmt, io};",
-        r"use std::fmt::{self, Result};
-use std::io;",
+        r"use std::fmt::Result;
+use std::{fmt, io};",
     )
 }