mirror of
https://github.com/rust-lang/rust-analyzer.git
synced 2025-10-01 11:31:15 +00:00
fix: disable assist for documented functions
This commit is contained in:
parent
3a82548c5e
commit
220137f1cf
@ -41,7 +41,10 @@ pub(crate) fn generate_documentation_template(
|
|||||||
) -> Option<()> {
|
) -> Option<()> {
|
||||||
let name = ctx.find_node_at_offset::<ast::Name>()?;
|
let name = ctx.find_node_at_offset::<ast::Name>()?;
|
||||||
let ast_func = name.syntax().parent().and_then(ast::Fn::cast)?;
|
let ast_func = name.syntax().parent().and_then(ast::Fn::cast)?;
|
||||||
if is_in_trait_impl(&ast_func) || !is_public(&ast_func) {
|
if is_in_trait_impl(&ast_func)
|
||||||
|
|| !is_public(&ast_func)
|
||||||
|
|| ast_func.doc_comments().next().is_some()
|
||||||
|
{
|
||||||
return None;
|
return None;
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -70,9 +73,6 @@ pub(crate) fn generate_documentation_template(
|
|||||||
doc_lines.append(&mut lines);
|
doc_lines.append(&mut lines);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if ast_func.doc_comments().next().is_some() {
|
|
||||||
doc_lines.push("--- OLD VERSION BELOW ---".into());
|
|
||||||
}
|
|
||||||
builder.insert(text_range.start(), documentation_from_lines(doc_lines, indent_level));
|
builder.insert(text_range.start(), documentation_from_lines(doc_lines, indent_level));
|
||||||
},
|
},
|
||||||
)
|
)
|
||||||
@ -501,6 +501,17 @@ mod ParentPrivateModule {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn not_applicable_if_function_already_documented() {
|
||||||
|
check_assist_not_applicable(
|
||||||
|
generate_documentation_template,
|
||||||
|
r#"
|
||||||
|
/// Some documentation here
|
||||||
|
pub fn $0documented_function() {}
|
||||||
|
"#,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn supports_noop_function() {
|
fn supports_noop_function() {
|
||||||
check_assist(
|
check_assist(
|
||||||
|
Loading…
x
Reference in New Issue
Block a user