itsscb/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-25 11:17:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #20333 from Veykril/push-xmulpqkxrytn

Browse Source 
fix: Do not require all rename definitions to be renameable
This commit is contained in:
Lukas Wirth 2025-07-29 06:42:28 +00:00 committed by GitHub
commit 4bcc293637
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
crates/ide/src/rename.rs
View File

@ -35,13 +35,8 @@ pub(crate) fn prepare_rename(
let syntax = source_file.syntax(); let syntax = source_file.syntax();
let res = find_definitions(&sema, syntax, position, &Name::new_symbol_root(sym::underscore))? let res = find_definitions(&sema, syntax, position, &Name::new_symbol_root(sym::underscore))?
.map(|(frange, kind, def, _, _)| { .filter(|(_, _, def, _, _)| def.range_for_rename(&sema).is_some())
// ensure all ranges are valid .map(|(frange, kind, _, _, _)| {
if def.range_for_rename(&sema).is_none() {
bail!("No references found at position")
}
always!( always!(
frange.range.contains_inclusive(position.offset) frange.range.contains_inclusive(position.offset)
&& frange.file_id == position.file_id && frange.file_id == position.file_id