Auto merge of #16846 - roife:fix-issue16826, r=Veykril

Browse Source

fix: incorrect handling of `use` and panic issue in `extract_module`.

fix #16826

This PR includes the following changes:

1. Simplify the implementation partially, removing many unnecessary loops and `clone()`.

2. When it is found that the top level of the selection contains a `use` statement, a copy of the `use` will be reinserted before extraction. (#16826)

3. Fixed an issue during `extract_module`, where if the top level of the selected part contains `A` and `use A::B`, it caused a duplication of `use A`.

...

This commit is contained in:

bors 2024-03-16 17:35:49 +00:00

parent b94c2852fa 10aa999c74

commit 5ecace48f6

1 changed files with 338 additions and 408 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

746

crates/ide-assists/src/handlers/extract_module.rs

File diff suppressed because it is too large Load Diff