itsscb/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-01 11:31:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add the comment why HasSource::source() returns Option

Browse Source
This commit is contained in:
Tetsuharu Ohzeki 2023-06-26 17:05:13 +09:00
parent b092b45484
commit 7b418d3a8c
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/hir/src/has_source.rs
View File

@ -21,6 +21,10 @@ pub trait HasSource {
/// Fetches the definition's source node. /// Fetches the definition's source node.
/// Using [`crate::Semantics::source`] is preferred when working with [`crate::Semantics`], /// Using [`crate::Semantics::source`] is preferred when working with [`crate::Semantics`],
/// as that caches the parsed file in the semantics' cache. /// as that caches the parsed file in the semantics' cache.
///
/// The current some implementations can return `InFile` instead of `Option<InFile>`.
/// But we made this method `Option` to support rlib in the future
/// by https://github.com/rust-lang/rust-analyzer/issues/6913
fn source(self, db: &dyn HirDatabase) -> Option<InFile<Self::Ast>>; fn source(self, db: &dyn HirDatabase) -> Option<InFile<Self::Ast>>;
} }