itsscb/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-01 11:31:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

rename combine -> or

Browse Source 
This way we match API of Option

https://doc.rust-lang.org/std/option/enum.Option.html#method.or
This commit is contained in:
Aleksey Kladov 2019-02-11 17:29:20 +03:00
parent 821d980fd9
commit 8cafdb3a99
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/ra_hir/src/nameres.rs
View File

@ -135,7 +135,7 @@ impl<T> PerNs<T> {
PerNs { types: self.types.as_ref(), values: self.values.as_ref() } PerNs { types: self.types.as_ref(), values: self.values.as_ref() }
} }
pub fn combine(self, other: PerNs<T>) -> PerNs<T> { pub fn or(self, other: PerNs<T>) -> PerNs<T> {
PerNs { types: self.types.or(other.types), values: self.values.or(other.values) } PerNs { types: self.types.or(other.types), values: self.values.or(other.values) }
} }
@ -439,7 +439,7 @@ impl ItemMap {
let from_extern_prelude = let from_extern_prelude =
self.extern_prelude.get(name).map_or(PerNs::none(), |&it| PerNs::types(it)); self.extern_prelude.get(name).map_or(PerNs::none(), |&it| PerNs::types(it));
from_scope.combine(from_extern_prelude) from_scope.or(from_extern_prelude)
} }
// Returns Yes if we are sure that additions to `ItemMap` wouldn't change // Returns Yes if we are sure that additions to `ItemMap` wouldn't change

2
crates/ra_hir/src/resolve.rs
View File

@ -59,7 +59,7 @@ impl Resolver {
pub fn resolve_name(&self, name: &Name) -> PerNs<Resolution> { pub fn resolve_name(&self, name: &Name) -> PerNs<Resolution> {
let mut resolution = PerNs::none(); let mut resolution = PerNs::none();
for scope in self.scopes.iter().rev() { for scope in self.scopes.iter().rev() {
resolution = resolution.combine(scope.resolve_name(name)); resolution = resolution.or(scope.resolve_name(name));
if resolution.is_both() { if resolution.is_both() {
return resolution; return resolution;
} }