itsscb/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-01 11:31:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Avoid .unwrap() when running the discover command

Browse Source 
Previously, the following configuration in settings.json:

    "rust-analyzer.workspace.discoverConfig": {
        "command": [
            "oops",
            "develop-json",
            "{arg}"
        ],
        "progressLabel": "rust-analyzer",
        "filesToWatch": [
            "BUCK",
            "TARGETS"
        ]
    },

Would previously cause a crash in rust-analyzer:

    thread 'LspServer' panicked at crates/rust-analyzer/src/main_loop.rs:776:84:
    called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }

Instead, use more specific panic messages.
This commit is contained in:
Wilfred Hughes 2025-06-30 14:46:53 +01:00
parent 3816d0ae53
commit a50b7b6b4e
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
crates/rust-analyzer/src/main_loop.rs
View File

@ -783,9 +783,14 @@ impl GlobalState {
DiscoverProjectParam::Path(it) => DiscoverArgument::Path(it), DiscoverProjectParam::Path(it) => DiscoverArgument::Path(it),
}; };
let handle = let handle = discover.spawn(
discover.spawn(arg, &std::env::current_dir().unwrap()).unwrap(); arg,
self.discover_handle = Some(handle); &std::env::current_dir()
.expect("Failed to get cwd during project discovery"),
);
self.discover_handle = Some(handle.unwrap_or_else(|e| {
panic!("Failed to spawn project discovery command: {e}")
}));
} }
} }
} }