itsscb/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-01 11:31:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge #4793

Browse Source 
4793: Don't @ people in commit messages r=matklad a=matklad



bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
This commit is contained in:
bors[bot] 2020-06-08 11:20:01 +00:00 committed by GitHub
commit a5f427ced3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
docs/dev/README.md
View File

@ -261,6 +261,14 @@ fn frobnicate(walrus: Option<Walrus>) {
} }
``` ```
## Commit Style
We don't have specific rules around git history hygiene.
Maintaining clean git history is encouraged, but not enforced.
We use rebase workflow, it's OK to rewrite history during PR review process.
Avoid @mentioning people in commit messages, as such messages create a lot of duplicate notification traffic during rebases.
# Architecture Invariants # Architecture Invariants
This section tries to document high-level design constraints, which are not This section tries to document high-level design constraints, which are not