itsscb/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-28 11:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #19033 from ChayimFriedman2/span-1

Browse Source 
fix: Make proc_macro span's line & column 1-indexed, as documented
This commit is contained in:
Chayim Refael Friedman 2025-01-26 06:41:54 +00:00 committed by GitHub
commit be9710ea6f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/proc-macro-srv/src/server_impl/rust_analyzer_span.rs
View File

@ -392,12 +392,12 @@ impl server::Span for RaSpanServer {
fn line(&mut self, _span: Self::Span) -> usize { fn line(&mut self, _span: Self::Span) -> usize {
// FIXME requires db to resolve line index, THIS IS NOT INCREMENTAL // FIXME requires db to resolve line index, THIS IS NOT INCREMENTAL
0 1
} }
fn column(&mut self, _span: Self::Span) -> usize { fn column(&mut self, _span: Self::Span) -> usize {
// FIXME requires db to resolve line index, THIS IS NOT INCREMENTAL // FIXME requires db to resolve line index, THIS IS NOT INCREMENTAL
0 1
} }
} }

4
crates/proc-macro-srv/src/server_impl/token_id.rs
View File

@ -291,11 +291,11 @@ impl server::Span for TokenIdServer {
} }
fn line(&mut self, _span: Self::Span) -> usize { fn line(&mut self, _span: Self::Span) -> usize {
0 1
} }
fn column(&mut self, _span: Self::Span) -> usize { fn column(&mut self, _span: Self::Span) -> usize {
0 1
} }
} }