From 06705a628d18f5efc9ef95d763d6167cdd7732be Mon Sep 17 00:00:00 2001 From: Lukas Wirth Date: Sat, 29 Nov 2025 20:54:34 +0100 Subject: [PATCH] minor: Option-box `crate_lang_items` query result --- crates/hir-def/src/lang_item.rs | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/crates/hir-def/src/lang_item.rs b/crates/hir-def/src/lang_item.rs index 31e9d8749d..390c9ab39f 100644 --- a/crates/hir-def/src/lang_item.rs +++ b/crates/hir-def/src/lang_item.rs @@ -31,8 +31,8 @@ impl_from!( ); /// Salsa query. This will look for lang items in a specific crate. -#[salsa_macros::tracked(returns(ref))] -pub fn crate_lang_items(db: &dyn DefDatabase, krate: Crate) -> LangItems { +#[salsa_macros::tracked(returns(as_deref))] +pub fn crate_lang_items(db: &dyn DefDatabase, krate: Crate) -> Option> { let _p = tracing::info_span!("crate_lang_items_query").entered(); let mut lang_items = LangItems::default(); @@ -93,7 +93,7 @@ pub fn crate_lang_items(db: &dyn DefDatabase, krate: Crate) -> LangItems { } } - lang_items + if lang_items.is_empty() { None } else { Some(Box::new(lang_items)) } } /// Salsa query. Look for a lang items, starting from the specified crate and recursively @@ -102,7 +102,7 @@ pub fn crate_lang_items(db: &dyn DefDatabase, krate: Crate) -> LangItems { pub fn lang_items(db: &dyn DefDatabase, start_crate: Crate) -> LangItems { let _p = tracing::info_span!("lang_items_query").entered(); - let mut result = crate_lang_items(db, start_crate).clone(); + let mut result = crate_lang_items(db, start_crate).cloned().unwrap_or_default(); // Our `CrateGraph` eagerly inserts sysroot dependencies like `core` or `std` into dependencies // even if the target crate has `#![no_std]`, `#![no_core]` or shadowed sysroot dependencies @@ -173,6 +173,10 @@ macro_rules! language_item_table { } impl LangItems { + fn is_empty(&self) -> bool { + $( self.$lang_item.is_none() )&&* + } + /// Merges `self` with `other`, with preference to `self` items. fn merge_prefer_self(&mut self, other: &Self) { $( self.$lang_item = self.$lang_item.or(other.$lang_item); )*