itsscb/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-01 11:31:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #18714 from Veykril/push-krxvsqwrokwp

Browse Source 
fix: Do not ask the client to resolve for non existing label details
This commit is contained in:
Lukas Wirth 2024-12-18 13:24:53 +00:00 committed by GitHub
commit e1b7d77ead
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
crates/rust-analyzer/src/lsp/to_proto.rs
View File

@ -372,9 +372,11 @@ fn completion_item(
};
if config.completion_label_details_support() {
let has_label_details =
item.label.detail_left.is_some() || item.label.detail_left.is_some();
if fields_to_resolve.resolve_label_details {
something_to_resolve |= true;
} else if item.label.detail_left.is_some() || item.label.detail_left.is_some() {
something_to_resolve |= has_label_details;
} else if has_label_details {
lsp_item.label_details = Some(lsp_types::CompletionItemLabelDetails {
detail: item.label.detail_left.clone(),
description: item.label.detail_right.clone(),