From e62e926a8a6e2446a1bb0908942247a63580f0a1 Mon Sep 17 00:00:00 2001
From: Tianyi Song <42670338+tysg@users.noreply.github.com>
Date: Fri, 28 Jan 2022 16:15:23 +0800
Subject: [PATCH] Use text range of name after macro expansion

---
 crates/ide/src/rename.rs    | 28 ++++++++++++++++++++++++++++
 crates/ide_db/src/rename.rs | 13 ++++++-------
 2 files changed, 34 insertions(+), 7 deletions(-)

diff --git a/crates/ide/src/rename.rs b/crates/ide/src/rename.rs
index 971bcede5a..daba317e42 100644
--- a/crates/ide/src/rename.rs
+++ b/crates/ide/src/rename.rs
@@ -1133,6 +1133,34 @@ pub mod foo$0;
         )
     }
 
+    #[test]
+    fn test_rename_mod_in_macro() {
+        check(
+            "bar",
+            r#"
+//- /foo.rs
+
+//- /lib.rs
+macro_rules! submodule {
+    ($name:ident) => {
+        mod $name;
+    };
+}
+
+submodule!($0foo);
+"#,
+            r#"
+macro_rules! submodule {
+    ($name:ident) => {
+        mod $name;
+    };
+}
+
+submodule!(bar);
+"#,
+        )
+    }
+
     #[test]
     fn test_enum_variant_from_module_1() {
         cov_mark::check!(rename_non_local);
diff --git a/crates/ide_db/src/rename.rs b/crates/ide_db/src/rename.rs
index 4392ae3e5a..cf511feb15 100644
--- a/crates/ide_db/src/rename.rs
+++ b/crates/ide_db/src/rename.rs
@@ -25,7 +25,6 @@ use std::fmt;
 use base_db::{AnchoredPathBuf, FileId, FileRange};
 use either::Either;
 use hir::{AsAssocItem, FieldSource, HasSource, InFile, ModuleSource, Semantics};
-use stdx::never;
 use syntax::{
     ast::{self, HasName},
     AstNode, SyntaxKind, TextRange, T,
@@ -188,16 +187,16 @@ fn rename_mod(
         source_change.push_file_system_edit(move_file);
     }
 
-    if let Some(InFile { file_id, value: decl_source }) = module.declaration_source(sema.db) {
+    if let Some(InFile { file_id, value: _ }) = module.declaration_source(sema.db) {
         let file_id = file_id.original_file(sema.db);
-        match decl_source.name() {
-            Some(name) => source_change.insert_source_edit(
+        if let Some(file_range) = Definition::Module(module).range_for_rename(sema) {
+            source_change.insert_source_edit(
                 file_id,
-                TextEdit::replace(name.syntax().text_range(), new_name.to_string()),
-            ),
-            _ => never!("Module source node is missing a name"),
+                TextEdit::replace(file_range.range, new_name.to_string()),
+            )
         }
     }
+
     let def = Definition::Module(module);
     let usages = def.usages(sema).all();
     let ref_edits = usages.iter().map(|(&file_id, references)| {